Differential D4075

Refactor weighted list and value
DraftPublic
Actions

Authored by dereckson on Sat, Apr 18, 11:38.

Details

Reviewers: None

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Test Failures

Branch

follow-up-for-doc

Build Status

Buildable 6628
Build 6912: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/home/dereckson/dev/keruald/_monorepo/core/omnitools/tests/Collections/WeightedListTest.php
	0 ms	/home/dereckson/dev/keruald/_monorepo/core/omnitools/tests/Collections/WeightedValueTest.php

Event Timeline

dereckson created this revision.Sat, Apr 18, 11:38

dereckson held this revision as a draft.

Harbormaster completed remote builds in B6628: Diff 10638.Sat, Apr 18, 11:38

This change is split from D2810 as it goes beyond documentation effort.

It needs to be revisited as it introduces an array with an empty string instead of an empty array in that test:

1) Keruald\OmniTools\Tests\HTTP\Requests\AcceptedLanguagesTest::testGetLanguageCodesWithBlankInformation
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
+    0 => ''
 )