Refactor DateStamp with constructor property promotion
Needs ReviewPublic
Actions

Authored by dereckson on Apr 18 2026, 11:56.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 28, 20:35

	Unknown Object (File)
	Sat, May 23, 07:21

	Unknown Object (File)
	Sat, May 23, 04:51

	Unknown Object (File)
	Fri, May 22, 21:19

	Unknown Object (File)
	Fri, May 22, 08:54

	Unknown Object (File)
	Fri, May 22, 01:15

	Unknown Object (File)
	Thu, May 21, 19:53

	Unknown Object (File)
	Thu, May 21, 19:20

View All 43 Files

Subscribers

Duranzed

This revision needs review, but there are no reviewers specified.

Details

Reviewers: None

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Tests Passed

Branch

follow-up-for-doc-ii

Build Status

Buildable 6708
Build 6996: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Apr 18 2026, 11:56

dereckson created this revision.

Harbormaster completed remote builds in B6629: Diff 10639.Apr 18 2026, 11:56

The refactor looks good, but Harbormaster reports unit test fails in:

omnitools/tests/DateTime/DateStampTest.php
omnitools/tests/Reflection/CodeClassTest.php

And fromUnixTime() changed from accepting a nullable/default argument to requiring an int, with now() replacing the no-argument usage.
Could you confirm all no-argument fromUnixTime() calls have been migrated, and fix or explain the failing unit tests?