Details
Details
- Reviewers
dereckson
Diff Detail
Diff Detail
- Repository
- rKERUALD Keruald libraries development repository
- Lint
Lint Passed - Unit
Tests Passed - Branch
- follow-up-for-doc-ii
- Build Status
Buildable 6708 Build 6996: arc lint + arc unit
Event Timeline
Comment Actions
The refactor looks good, but Harbormaster reports unit test fails in:
- omnitools/tests/DateTime/DateStampTest.php
- omnitools/tests/Reflection/CodeClassTest.php
And fromUnixTime() changed from accepting a nullable/default argument to requiring an int, with now() replacing the no-argument usage.
Could you confirm all no-argument fromUnixTime() calls have been migrated, and fix or explain the failing unit tests?
Comment Actions
For reference, to launch unit tests from Arcanist was broken as Xdebug was invoked without code coverage support.
https://github.com/nasqueron/arcanist/commit/2287f8768605272aba2544fa9f4192623f7d05ae fixed the issue.