Page MenuHomeDevCentral

Improve tests for Collection engines
ClosedPublic

Authored by dereckson on Aug 21 2026, 04:02.
Tags
None
Referenced Files
F52484192: D4176.id10942.diff
Fri, Oct 2, 22:03
Unknown Object (File)
Fri, Oct 2, 15:39
Unknown Object (File)
Wed, Sep 30, 12:51
Unknown Object (File)
Wed, Sep 30, 08:55
Unknown Object (File)
Tue, Sep 29, 12:33
Unknown Object (File)
Mon, Sep 28, 19:42
Unknown Object (File)
Mon, Sep 28, 06:55
Unknown Object (File)
Sun, Sep 27, 22:13
Subscribers
None

Details

Summary

Address Collection tests issues:

  • Skip explicitly tests when database extension isn't available
  • Harden delete / clean-up mechanics
Test Plan

Run tests for Waystone\Workspaces\Tests\Engines\Collection\ namespace

Diff Detail

Repository
rOBSIDIAN Obsidian Workspaces
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.

Arc is still unable to parse correctly our tests suite.

Local workstation
$ phpunit workspaces/tests/Engines/Collection/                        
Switching to Composer phpunit:
PHPUnit 13.3.1 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.21
Configuration: /datacube/dereckson/dev/nasqueron/obsidian/phpunit.xml

.......SSSSSSSS......                                             21 / 21 (100%)

Time: 00:00.015, Memory: 8.00 MB

OK, but some tests were skipped!
Tests: 21, Assertions: 124, Skipped: 8.

Note on WindRiver we can still have:
Error: Class "SQLite3" not found

dereckson edited the test plan for this revision. (Show Details)
WindRiver
$ phpunit workspaces/tests/Engines/Collection/
Switching to Composer phpunit:
PHPUnit 12.5-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.33
Configuration: /home/dereckson/dev/nasqueron/obsidian/obsidian/phpunit.xml

.......SSSSSSSSSSSSSS                                             21 / 21 (100%)

Time: 00:00.048, Memory: 16.00 MB

OK, but some tests were skipped!
Tests: 21, Assertions: 61, Skipped: 14.
This revision is now accepted and ready to land.Aug 21 2026, 04:10
This revision was landed with ongoing or failed builds.Aug 21 2026, 04:11
This revision was automatically updated to reflect the committed changes.

Content merged is actually D4177 diff, ie this diff + skip when SQLite3 extension is not available.