Improve tests for Collection engines
ClosedPublic
Actions

Authored by dereckson on Fri, Aug 21, 04:02.

Details

Reviewers

dereckson

Commits

rOBSIDIAN9dc2991cb81a: Improve tests for Collection engines

Summary

Address Collection tests issues:

Skip explicitly tests when database extension isn't available
Harden delete / clean-up mechanics

Test Plan

Run tests for Waystone\Workspaces\Tests\Engines\Collection\ namespace

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

Test Failures

Branch

main

Build Status

Buildable 6819
Build 7107: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/tmp/obsidian-upgrade/workspaces/tests/Engines/Collection/FilesCollectionTest.php
	0 ms	/tmp/obsidian-upgrade/workspaces/tests/Engines/Collection/MongoDBCollectionTest.php
	0 ms	/tmp/obsidian-upgrade/workspaces/tests/Engines/Collection/MySQLCollectionTest.php
	0 ms	/tmp/obsidian-upgrade/workspaces/tests/Engines/Collection/SQLiteCollectionTest.php

Event Timeline

dereckson requested review of this revision.Fri, Aug 21, 04:02

dereckson created this revision.

Harbormaster completed remote builds in B6819: Diff 10940.Fri, Aug 21, 04:02

Arc is still unable to parse correctly our tests suite.

Local workstation

$ phpunit workspaces/tests/Engines/Collection/                        
Switching to Composer phpunit:
PHPUnit 13.3.1 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.21
Configuration: /datacube/dereckson/dev/nasqueron/obsidian/phpunit.xml

.......SSSSSSSS......                                             21 / 21 (100%)

Time: 00:00.015, Memory: 8.00 MB

OK, but some tests were skipped!
Tests: 21, Assertions: 124, Skipped: 8.

Note on WindRiver we can still have:
Error: Class "SQLite3" not found

WindRiver

$ phpunit workspaces/tests/Engines/Collection/
Switching to Composer phpunit:
PHPUnit 12.5-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.33
Configuration: /home/dereckson/dev/nasqueron/obsidian/obsidian/phpunit.xml

.......SSSSSSSSSSSSSS                                             21 / 21 (100%)

Time: 00:00.048, Memory: 16.00 MB

OK, but some tests were skipped!
Tests: 21, Assertions: 61, Skipped: 14.