Page MenuHomeDevCentral

Improve tests for Collection engines
ClosedPublic

Authored by dereckson on Aug 21 2026, 04:02.
Tags
None
Referenced Files
F53352595: D4176.id10940.diff
Thu, Oct 8, 23:17
F53318128: D4176.diff
Thu, Oct 8, 14:25
F53309024: D4176.id.diff
Thu, Oct 8, 12:02
F53309013: D4176.id.diff
Thu, Oct 8, 12:02
Unknown Object (File)
Wed, Oct 7, 21:37
Unknown Object (File)
Wed, Oct 7, 20:34
Unknown Object (File)
Wed, Oct 7, 18:27
Unknown Object (File)
Wed, Oct 7, 15:57
Subscribers
None

Details

Summary

Address Collection tests issues:

  • Skip explicitly tests when database extension isn't available
  • Harden delete / clean-up mechanics
Test Plan

Run tests for Waystone\Workspaces\Tests\Engines\Collection\ namespace

Diff Detail

Repository
rOBSIDIAN Obsidian Workspaces
Lint
No Lint Coverage
Unit
Test Failures
Branch
main
Build Status
Buildable 6819
Build 7107: arc lint + arc unit

Event Timeline

dereckson created this revision.

Arc is still unable to parse correctly our tests suite.

Local workstation
$ phpunit workspaces/tests/Engines/Collection/                        
Switching to Composer phpunit:
PHPUnit 13.3.1 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.21
Configuration: /datacube/dereckson/dev/nasqueron/obsidian/phpunit.xml

.......SSSSSSSS......                                             21 / 21 (100%)

Time: 00:00.015, Memory: 8.00 MB

OK, but some tests were skipped!
Tests: 21, Assertions: 124, Skipped: 8.

Note on WindRiver we can still have:
Error: Class "SQLite3" not found

dereckson edited the test plan for this revision. (Show Details)
WindRiver
$ phpunit workspaces/tests/Engines/Collection/
Switching to Composer phpunit:
PHPUnit 12.5-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.33
Configuration: /home/dereckson/dev/nasqueron/obsidian/obsidian/phpunit.xml

.......SSSSSSSSSSSSSS                                             21 / 21 (100%)

Time: 00:00.048, Memory: 16.00 MB

OK, but some tests were skipped!
Tests: 21, Assertions: 61, Skipped: 14.
This revision is now accepted and ready to land.Aug 21 2026, 04:10
This revision was landed with ongoing or failed builds.Aug 21 2026, 04:11
This revision was automatically updated to reflect the committed changes.

Content merged is actually D4177 diff, ie this diff + skip when SQLite3 extension is not available.