Improve DatabaseShell code comments and exceptions
ClosedPublic
Actions

Authored by dereckson on Jun 27 2016, 11:40.

Details

Reviewers

dereckson

Commits

rGROVE699661550c8a: Improve DatabaseShell code comments and exceptions

Summary

Documentation of this class now fully contains type hinting.

Side edit: references variable should also be
initialized before method call.

Test Plan

This is a no op change.

./artisan db:shell

Diff Detail

Repository

rGROVE Auth Grove

Lint

Lint Passed

Unit

Tests Passed

Branch

master

Build Status

Buildable 590
Build 706: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1028.Jun 27 2016, 11:40

dereckson retitled this revision from to Improve DatabaseShell code comments and exceptions.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jun 27 2016, 11:51

dereckson updated this object.

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jun 27 2016, 11:52

Closed by commit rGROVE699661550c8a: Improve DatabaseShell code comments and exceptions (authored by dereckson, committed by dereckson). · Explain WhyJun 27 2016, 11:57

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Console/

Commands/

DatabaseShell.php

46 lines

Diff 1028

View Options

app/Console/Commands/DatabaseShell.php

Improve DatabaseShell code comments and exceptionsClosedPublicActions