Page MenuHomeDevCentral
Differential D445

[WIP] [DO NOT MERGE] External accounts
Changes PlannedPublic
Actions

Authored by dereckson on Jul 2 2016, 08:51.
Tags
None
Referenced Files
F2964755: D445.id1267.diff
Sat, May 18, 22:43
F2962266: D445.id1086.diff
Sat, May 18, 14:39
F2962201: D445.id1147.diff
Sat, May 18, 14:33
F2962181: D445.id1125.diff
Sat, May 18, 14:31
F2961666: D445.id1277.diff
Sat, May 18, 13:48
F2958262: D445.diff
Sat, May 18, 05:18
F2957267: D445.id1126.diff
Sat, May 18, 02:51
F2956625: D445.id1103.diff
Sat, May 18, 00:49
View All Files
Subscribers
xcombelle

Details

Reviewers
dereckson
Maniphest Tasks
T336: Add login capabilities through external services
Summary

Allow to log in to external accounts.

Pretty ready, but still need:

  • actions logging to provide both to users and site administrators an audit
  • UI to link
  • Undo stuff should be committed as a separate commit (don't forget Controller).
Test Plan
  • unit tests for LinkExternalUserAccount
  • integration tests still to prepare
  • each login and link scenario manually tested and audited

Diff Detail

Repository
rGROVE Auth Grove
Lint
Lint Passed
Unit
Tests Passed
Branch
WIP
Build Status
Buildable 746
Build 873: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1078.Jul 2 2016, 08:51
dereckson retitled this revision from to [WIP] [DO NOT MERGE] External accounts.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson mentioned this in D447: UserExternalSource: cast user_id property as integer.Jul 2 2016, 08:59
dereckson mentioned this in rGROVE80d89862df06: UserExternalSource: cast user_id property as integer.Jul 2 2016, 08:59
dereckson updated this revision to Diff 1083.Jul 2 2016, 09:01
dereckson edited edge metadata.

Rebased against D446 and D447.

dereckson planned changes to this revision.Jul 2 2016, 09:13

Two autonomous commits to extract:

  • routing: config/auth.php, app/Http/Controllers/Auth/AuthController.php
  • events listener from config: config/app.php, app/Listeners/ExternalUserListener.php
dereckson updated this revision to Diff 1086.Jul 2 2016, 09:14
dereckson edited edge metadata.

Proofing code comments and selection of autonomous parts (see previous comment)

dereckson updated this revision to Diff 1091.Jul 2 2016, 15:10

Rebased against D449.

dereckson updated this revision to Diff 1097.Jul 2 2016, 18:32

Rebased.

dereckson mentioned this in D453: Register events listeners through configuration.Jul 2 2016, 19:47
dereckson mentioned this in rGROVE036351b2607a: Register events listeners through configuration.Jul 2 2016, 19:49
dereckson updated this revision to Diff 1103.Jul 2 2016, 19:52

Rebased against D453.

dereckson updated this revision to Diff 1110.Jul 3 2016, 00:16

Rebased.

dereckson added a task: T336: Add login capabilities through external services.Jul 3 2016, 21:00
dereckson updated this revision to Diff 1111.Jul 3 2016, 23:47

authurl() is now a global function, not a directive,
to avoid URLs to be subst'ed at template compile time.

dereckson mentioned this in D457: Transitional change to restore app/Listeners empty folder.Jul 3 2016, 23:56
dereckson mentioned this in rGROVE9c59de083c98: Transitional change to restore app/Listeners empty folder.Jul 3 2016, 23:59
dereckson mentioned this in D459: Service provider for helper global functions.Jul 4 2016, 00:05
dereckson mentioned this in rGROVEa8b157e11a91: Service provider for helper global functions.Jul 4 2016, 00:07
dereckson updated this revision to Diff 1119.Jul 4 2016, 00:09

Rebased

dereckson mentioned this in D462: Add Font Awesome.Jul 6 2016, 00:20
dereckson mentioned this in rGROVE2dc11d85d900: Add Font Awesome.Jul 6 2016, 00:21
dereckson updated this revision to Diff 1124.Jul 6 2016, 00:26
  • Undo capability
  • UI is working
  • Rebased against D462

Undo should probably released as a keruald/undo library.

Logging and audit should be implemented before to merge this,
so we can also implement logging when we ship this feature.

dereckson updated this revision to Diff 1125.Jul 6 2016, 00:40

Previous test issue was introduced when we added the source_username field:
our mock didn't have a nickname property.

I noticed interface offers getNickname and getId method, but public properties
are added by the final implementation. We'll so use get methods.

dereckson updated this revision to Diff 1126.Jul 6 2016, 00:42

Space between the trash icon and Delete

dereckson mentioned this in T905: UndoStack.Jul 8 2016, 13:16
dereckson added inline comments.Jul 8 2016, 13:24
app/Undo/UndoStore.php
112 ↗(On Diff #1126)

MediaWiki uses fnv1a32 since June 22, instead of sha1.

They wanted an hash with the following specifications:

  • Already implemented in PHP
  • Easy to implement in JavaScript
  • Fast
  • Collision-resistant

FNV-1 is their winner.

https://phabricator.wikimedia.org/rMWdfd046412fc94b7e5788c04a24d2db08480f75c6

dereckson updated this revision to Diff 1145.Jul 9 2016, 20:55

Constructor for UndoStore

dereckson updated this revision to Diff 1146.Jul 9 2016, 20:56

Improve code comment

dereckson updated this revision to Diff 1147.Jul 10 2016, 00:37

+UndoStack

dereckson updated this revision to Diff 1252.Jul 17 2016, 14:06

Tests in namespaces

dereckson updated this revision to Diff 1253.Jul 17 2016, 14:24

Use Eloquent relationships.

Eloquent provides mathods to abstract the relationships between models.

dereckson updated this revision to Diff 1254.Jul 17 2016, 15:54

UndoStack

dereckson updated this revision to Diff 1255.Jul 17 2016, 16:37

Fix UndoStack issue, more tests.

dereckson updated this revision to Diff 1256.Jul 17 2016, 16:40

UndoStack: InvalidArgumentException

dereckson updated this revision to Diff 1257.Jul 17 2016, 16:47

LIFO test

dereckson updated this revision to Diff 1258.Jul 17 2016, 18:17

More tests for UndoStack

dereckson updated this revision to Diff 1262.Jul 18 2016, 17:18

ExternalSourcesController uses UndoStack

We still need to offer somewhere an easier access to that stack.

dereckson updated this revision to Diff 1263.Jul 18 2016, 17:24

Local improvement for UndoStackTest class

dereckson updated this revision to Diff 1266.Jul 18 2016, 23:22

Rebased against b2d077f8b971.

dereckson updated this revision to Diff 1267.Jul 19 2016, 01:12

UndoStack and session

dereckson updated this revision to Diff 1268.Jul 19 2016, 01:15

Simplify ExternalSourcesController::undo

dereckson updated this revision to Diff 1269.Jul 19 2016, 01:16

UndoesOperation trait

dereckson updated this object.Jul 19 2016, 01:17
dereckson updated this revision to Diff 1270.Jul 19 2016, 01:40

Get rid of storeUndoToSession

dereckson updated this revision to Diff 1273.Jul 19 2016, 22:12

Rebased against D521 / e474ff1134ce

dereckson mentioned this in D522: Undo mechanism.Jul 19 2016, 23:00
dereckson mentioned this in rGROVE47f38d5bdc1c: Undo mechanism.Jul 20 2016, 01:18
dereckson updated this revision to Diff 1277.Jul 20 2016, 01:25

Rebased

dereckson mentioned this in D535: Require Laravel 5.2.41 for Session::increment().Jul 22 2016, 22:43
dereckson mentioned this in rGROVEd69820ed127c: Require Laravel 5.2.41 for Session::increment().Jul 22 2016, 22:47
dereckson planned changes to this revision.Oct 12 2017, 22:11
dereckson added a subscriber: xcombelle.
dereckson added inline comments.
app/Http/Controllers/Account/ExternalSourcesController.php
108

Ensure this method can't be called directly by a simple URL visit, but is handled through a CSRF token process (thanks @xcombelle).

Revision Contents
Changeset List

PathSize
4 lines
app/
Events/
31 lines
20 lines
Http/
Controllers/
Account/
151 lines
Auth/
72 lines
1 line
13 lines
Jobs/
91 lines
30 lines
30 lines
Listeners/
63 lines
101 lines
Models/
24 lines
22 lines
Services/
395 lines
config/
2 lines
17 lines
17 lines
database/
migrations/
47 lines
resources/
lang/
en/
13 lines
63 lines
3 lines
6 lines
views/
account/
external-sources/
50 lines
18 lines
14 lines
tests/
Controller/
Auth/
3 lines
Jobs/
133 lines

Diff 1277

View Options

.env.example

Loading...
View Options

app/Events/ExternalUserAuthorizeEvent.php

Loading...
View Options

app/Events/NewExternalUserAuthorizeEvent.php

Loading...
View Options

app/Http/Controllers/Account/ExternalSourcesController.php

Loading...
View Options

app/Http/Controllers/Auth/AuthController.php

Loading...
View Options

app/Http/Controllers/LoginDashboardController.php

Loading...
View Options

app/Http/routes.php

Loading...
View Options

app/Jobs/LinkExternalUserAccount.php

Loading...
View Options

app/Jobs/LogExternalUserAuthorize.php

Loading...
View Options

app/Jobs/LogLogin.php

Loading...
View Options

app/Listeners/.gitkeep

Loading...
View Options

app/Listeners/ExternalUserListener.php

Loading...
View Options

app/Listeners/PostLoginActionsListener.php

Loading...
View Options

app/Models/User.php

Loading...
View Options

app/Models/UserExternalSource.php

Loading...
View Options

app/Services/AuthenticatesExternalUsers.php

Loading...
View Options

config/app.php

Loading...
View Options

config/auth.php

Loading...
View Options

config/services.php

Loading...
View Options

database/migrations/2016_06_28_034600_create_users_external_sources_table.php

Loading...
View Options

resources/lang/en/auth.php

Loading...
View Options

resources/lang/en/externalsources.php

Loading...
View Options

resources/lang/en/login.php

Loading...
View Options

resources/lang/en/panel.php

Loading...
View Options

resources/views/account/external-sources/index.blade.php

Loading...
View Options

resources/views/app.blade.php

Loading...
View Options

resources/views/home.blade.php

Loading...
View Options

tests/Controller/Auth/AuthControllerTest.php

Loading...
View Options

tests/Jobs/LinkExternalUserAccountTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator