Page MenuHomeDevCentral

UserExternalSource: cast user_id property as integer
ClosedPublic

Authored by dereckson on Jul 2 2016, 08:59.
Tags
None
Referenced Files
F10360295: D447.id.diff
Wed, Jul 2, 00:24
F10345630: D447.id1081.diff
Tue, Jul 1, 06:40
Unknown Object (File)
Mon, Jun 30, 17:51
Unknown Object (File)
Sat, Jun 28, 13:52
Unknown Object (File)
Sat, Jun 28, 10:01
Unknown Object (File)
Sat, Jun 28, 10:00
Unknown Object (File)
Thu, Jun 26, 13:40
Unknown Object (File)
Thu, Jun 19, 05:19
Subscribers
None

Details

Summary

Code using the UserExternalSource model expects user ID to be
an integer, and not a string:

$externalUser = UserExternalSource::find(1);
// Does something with $externalUser->user_id

Eloquent allows to specify attributes casting with a $casts array.

Test Plan

Tested through D445 new unit test which provide:
$this->assertSame($externalUser->user_id, 1);

Diff Detail

Repository
rGROVE Auth Grove
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to UserExternalSource: cast user_id property as integer.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2016, 08:59
This revision was automatically updated to reflect the committed changes.