Page MenuHomeDevCentral

When no health information is available for a project, for example because it's new, there is no real point to include it to our dashboard.
ClosedPublic

Authored by dereckson on Jul 11 2016, 12:39.
Tags
None
Referenced Files
F3754848: D506.diff
Mon, Nov 18, 10:25
Unknown Object (File)
Tue, Nov 12, 15:12
Unknown Object (File)
Sat, Nov 9, 14:46
Unknown Object (File)
Sat, Nov 9, 05:40
Unknown Object (File)
Sat, Nov 9, 05:36
Unknown Object (File)
Sat, Nov 9, 05:32
Unknown Object (File)
Sat, Nov 9, 05:01
Unknown Object (File)
Wed, Oct 30, 19:38
Subscribers
None

Details

Summary

We so ignore projects raising an exception at parse time.

There is here a margin for improvement:
A next unless valid?(project) would be a more elegant
than to try the parse code and intercept exceptions.

To reduce cyclometric complexity, we extract the parser
code of one project into a parse_project method.

Fixes T920.

Test Plan

Test dashboard with a shiny new Jenkins job creating from php-template,
not yet built.

Diff Detail

Repository
rTOMMY Tommy
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningtommy.rb:21Metrics/AbcSizeRuboCop
Warningtommy.rb:21Metrics/MethodLengthRuboCop
Warningtommy.rb:26Metrics/LineLengthRuboCop
Warningtommy.rb:27Metrics/LineLengthRuboCop
Warningtommy.rb:29Metrics/LineLengthRuboCop
Warningtommy.rb:30Metrics/LineLengthRuboCop
Unit
No Test Coverage
Branch
master
Build Status
Buildable 708
Build 831: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to When no health information is available for a project, for example because it's new, there is no real point to include it to our dashboard..
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 11 2016, 12:39
This revision was automatically updated to reflect the committed changes.