Page MenuHomeDevCentral
Differential D571

Handle new RepositoryEvent actions
ClosedPublic
Actions

Authored by dereckson on Jul 25 2016, 14:27.
Tags
None
Referenced Files
F19007742: D571.id1388.diff
Mon, Dec 22, 22:03
F19002985: D571.id.diff
Mon, Dec 22, 21:17
F18979369: D571.diff
Mon, Dec 22, 16:59
F18965938: D571.id1387.diff
Mon, Dec 22, 14:23
F18962288: D571.id1386.diff
Mon, Dec 22, 13:23
F18959481: D571.id1386.diff
Mon, Dec 22, 12:56
F18953759: D571.id1387.diff
Mon, Dec 22, 11:33
F18951700: D571.id1386.diff
Mon, Dec 22, 11:08
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T935: GitHub delete repository is handled as a creation
Commits
rNOTIFcea98ec53a9e: Handle new RepositoryEvent actions
Summary

GitHub introduced new events:
https://developer.github.com/changes/2016-04-18-new-webhook-actions-are-live/#list-of-comprehensive-changes

This commit allows to handle deleted/publicized/privatized actions.

Fixes T935.

Test Plan

Unit tests updated.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
RepositoryEvent-new-events

Event Timeline

dereckson updated this revision to Diff 1386.Jul 25 2016, 14:27
dereckson retitled this revision from to Handle new RepositoryEvent actions.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson added a task: T935: GitHub delete repository is handled as a creation.
dereckson planned changes to this revision.Jul 25 2016, 14:27
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.

Check action value

dereckson updated this revision to Diff 1387.Jul 25 2016, 14:38
dereckson edited edge metadata.

Call isValidAction

dereckson accepted this revision.Jul 25 2016, 14:39
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 25 2016, 14:39
alken-orin added a subscriber: alken-orin.Jul 25 2016, 14:40

Build is green https://ci.nasqueron.org/job/test-notifications-phab/140/ for more details.

alken-orin added a comment.Jul 25 2016, 14:54

Build is green https://ci.nasqueron.org/job/test-notifications-phab/141/ for more details.

Closed by commit rNOTIFcea98ec53a9e: Handle new RepositoryEvent actions (authored by dereckson, committed by dereckson). · Explain WhyJul 25 2016, 15:07
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Analyzers/
GitHub/
Events/
20 lines80%
Loading...
resources/
lang/
en/
7 lines--
tests/
Analyzers/
GitHub/
Events/
23 lines--

Diff 1386

View Options

app/Analyzers/GitHub/Events/RepositoryEvent.php

Loading...
View Options

resources/lang/en/GitHub.php

Loading...
View Options

tests/Analyzers/GitHub/Events/RepositoryEventTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator