Page MenuHomeDevCentral

Copy correctly Foundation Icon fonts to assets/fonts/
ClosedPublic

Authored by dereckson on Aug 4 2016, 20:31.
Tags
None
Referenced Files
F3804883: D600.diff
Fri, Nov 29, 23:35
F3802912: D600.id1463.diff
Fri, Nov 29, 12:57
F3802911: D600.id1462.diff
Fri, Nov 29, 12:57
F3802857: D600.id.diff
Fri, Nov 29, 12:40
F3802834: D600.diff
Fri, Nov 29, 12:25
Unknown Object (File)
Fri, Nov 15, 05:02
Unknown Object (File)
Tue, Nov 12, 08:58
Unknown Object (File)
Sat, Nov 9, 17:06
Subscribers
None

Details

Summary

Currently, Foundation Icon fonts are copied in the CSS directory.

Instead, we serve them from a dedicated directory.

This change also:

  • avoids to copy svgs/ folder
  • selects .eot and not .eoff files
Test Plan
$ gulp build 
$ cd dist
$ tree
.
├── assets
│   ├── css
│   │   └── app.css
│   ├── fonts
│   │   ├── foundation-icons.eot
│   │   ├── foundation-icons.svg
│   │   ├── foundation-icons.ttf
│   │   └── foundation-icons.woff
│   ├── img
│   │   ├── 1280px-Beowulf_Manuscript.jpg
│   │   ├── logo-nasqueron.png
│   │   ├── logo-vikidia.png
│   │   ├── logo-wikimedia.png
│   │   └── logo-wolfplex.png
│   ├── js
│   │   └── app.js
│   └── scss
└── index.html

6 directories, 12 files

The extraneous scss/ folder will be handled in a follow-up separate fix.

Diff Detail

Repository
rVIPERWWW Dæghrefn website
Lint
Lint Passed
Unit
No Test Coverage
Branch
kill-extra-svg (branched from master)
Build Status
Buildable 883
Build 1024: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Copy correctly Foundation Icon fonts to assets/fonts/.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2016, 20:32
This revision was automatically updated to reflect the committed changes.