Details

Reviewers

Maniphest Tasks

T983: CLI command to get a notification payload from a service payload

Commits

rNOTIFb42260e53626: Add notifications:payload command

Summary

A CLI command to get a notification payload from a service payload.

The goal is to ease debug of consumers applications: you can get a
sample notification without the assistance of the message broker
for a specified problematic payload.

Fixes T983.

Test Plan

Used for D347.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

feature/get-notification-from-payload

Event Timeline

dereckson updated this revision to Diff 1518.Aug 19 2016, 10:48

dereckson retitled this revision from to Add notifications:payload command.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson updated this object.Aug 19 2016, 10:49

dereckson added a task: T983: CLI command to get a notification payload from a service payload.

dereckson planned changes to this revision.Aug 19 2016, 10:53

dereckson added inline comments.

app/Console/Commands/NotificationsPayload.php
10	Test me.
11	Not on an individual line.
115	ensureCorrectArgumentsCount() ?
121	Document me.
128	Document me.
133	Document me.

There is an issue in logic code too.

  [ErrorException]                           
  Undefined property: stdClass::$repository  
                                             

Exception trace:
 () at /home/ubuntu/workspace/notifications/app/Notifications/DockerHubNotification.php:47
 Illuminate\Foundation\Bootstrap\HandleExceptions->handleError() at /home/ubuntu/workspace/notifications/app/Notifications/DockerHubNotification.php:47
 Nasqueron\Notifications\Notifications\DockerHubNotification->getText() at /home/ubuntu/workspace/notifications/app/Notifications/DockerHubNotification.php:37
 Nasqueron\Notifications\Notifications\DockerHubNotification->__construct() at /home/ubuntu/workspace/notifications/app/Console/Commands/NotificationsPayload.php:124

Build is green https://ci.nasqueron.org/job/test-notifications-phab/155/ for more details.

More tests.

In D617#9435, @dereckson wrote:
There is an issue in logic code too.
[ErrorException]                           
Undefined property: stdClass::$repository

Payload was already a notification, not a DockerHub payload.