Page MenuHomeDevCentral
Differential D635

Simplify PhabricatorNotification and allow to use notifications:payload
ClosedPublic
Actions

Authored by dereckson on Aug 24 2016, 02:02.
Tags
None
Referenced Files
F52424783: D635.id1584.diff
Fri, Oct 2, 14:16
F52423353: D635.id1583.diff
Fri, Oct 2, 14:03
F52416020: D635.id1586.diff
Fri, Oct 2, 13:03
F52399430: D635.id1583.diff
Fri, Oct 2, 10:52
F52399407: D635.id1586.diff
Fri, Oct 2, 10:51
F52399324: D635.id1585.diff
Fri, Oct 2, 10:51
F52358216: D635.diff
Fri, Oct 2, 05:08
Unknown Object (File)
Tue, Sep 29, 14:27
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T984: Pick a format for Notifications::$rawContent property
Commits
rNOTIF9e6c1ca7831f: Simplify PhabricatorNotification and allow to use notifications:payload
Summary

With rNOTIF67730e913d04, Phabricator began to match other services.

We continue to simplify Phabricator classes and standardize constructors.

This change allows:

  • to use the notifications:payload command with Phabricator too
  • to use the same rawContent format (inline JSON) than other notifications
Test Plan

php artisan notifications:payload Phabricator storage/logs/PhabricatorPastePayload.json Nasqueron

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
payload-everywhere

Event Timeline

dereckson updated this revision to Diff 1583.Aug 24 2016, 02:02
dereckson retitled this revision from to Allow to use CLI notifications:payload command with Phabricator.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson updated this revision to Diff 1584.Aug 24 2016, 02:12
dereckson edited edge metadata.

More tests

alken-orin added a subscriber: alken-orin.Aug 24 2016, 02:23

Build is green https://ci.nasqueron.org/job/test-notifications-phab/183/ for more details.

alken-orin added a comment.Aug 24 2016, 02:28

Build is green https://ci.nasqueron.org/job/test-notifications-phab/184/ for more details.

dereckson retitled this revision from Allow to use CLI notifications:payload command with Phabricator to Simplify PhabricatorNotification and allow to use notifications:payload.Aug 24 2016, 03:00
dereckson updated this object.
dereckson edited edge metadata.
dereckson added a task: T984: Pick a format for Notifications::$rawContent property.
dereckson accepted this revision.Aug 24 2016, 03:02
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2016, 03:02
dereckson updated this revision to Diff 1585.Aug 24 2016, 03:03
dereckson edited edge metadata.

EOL at EOF

Closed by commit rNOTIF9e6c1ca7831f: Simplify PhabricatorNotification and allow to use notifications:payload (authored by dereckson, committed by dereckson). · Explain WhyAug 24 2016, 03:05
This revision was automatically updated to reflect the committed changes.
alken-orin added a comment.Aug 24 2016, 03:20

Build is green https://ci.nasqueron.org/job/test-notifications-phab/185/ for more details.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Console/
Commands/
19 lines100%
Loading...
Notifications/
19 lines--
Phabricator/
21 lines--
tests/
Console/
Commands/
16 lines--
Http/
21 lines--
data/
payloads/
1 line--

Diff 1584

View Options

app/Console/Commands/NotificationsPayload.php

Loading...
View Options

app/Notifications/PhabricatorNotification.php

Loading...
View Options

app/Phabricator/PhabricatorStory.php

Loading...
View Options

tests/Console/Commands/NotificationsPayloadTest.php

Loading...
View Options

tests/Http/PayloadFullTest.php

Loading...
View Options

tests/data/payloads/PhabricatorPastePayload.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator