Differential D639

New library to fetch a Mailgun stored message
ClosedPublic
Actions

Authored by dereckson on Sep 1 2016, 16:51.

Tags

None

Subscribers

None

Details

Reviewers

Maniphest Tasks

T1000: Detect builds issues with Docker images

Commits

rKMAILGUNcbdfbd39de48: New library to fetch a Mailgun stored message

Summary

Test Plan

Unit tests

Diff Detail

Repository

rKMAILGUN Keruald Mailgun

Lint

Lint OK

Unit

Unit Tests OK

Branch

master

Build Status

Buildable 970
Build 1160: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1598.Sep 1 2016, 16:51

dereckson retitled this revision from to New library to fetch a Mailgun stored message.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: Sandlayth.

dereckson added a task: T1000: Detect builds issues with Docker images.

Update commit range

dereckson planned changes to this revision.Sep 1 2016, 16:55

dereckson added inline comments.

CHANGELOG.md
8	\n
src/MailgunMessage.php
10	Test me!

Tests, \n

dereckson planned changes to this revision.Sep 1 2016, 17:13

dereckson added inline comments.

src/MailgunMessage.php
101	Not needed, as Client::request will alreadt throw this exception.

100% unit tests cover

Client → ClientInterface

Sandlayth accepted this revision.Sep 1 2016, 17:27

Sandlayth edited edge metadata.

This revision is now accepted and ready to land.Sep 1 2016, 17:27

dereckson added a child revision: D640: Add Mailgun support.Sep 1 2016, 19:40

abcdefg → abcdef

Closed by commit rKMAILGUNcbdfbd39de48: New library to fetch a Mailgun stored message (authored by dereckson). · Explain WhySep 1 2016, 20:47

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Coverage (All)	Coverage (Touched)	Packages
A	M		.arcconfig (5 lines)	-	-
A	M		.arclint (41 lines)	-	-
A	M		.gitignore (2 lines)	-	-
A	M		CHANGELOG.md (7 lines)	-	-
A	M		README.md (5 lines)	-	-
A	M		composer.json (43 lines)	-	-
A	M		phpunit.xml (13 lines)	-	-
A	M		src/MailgunMessage.php (132 lines)	100%	Loading...
A	M		src/MailgunMessageFactory.php (86 lines)	100%	Loading...
A	M		tests/MailgunMessageFactoryTest.php (55 lines)	-	-
A	M		tests/MailgunMessageTest.php (68 lines)	-	-
A	M		tests/WithMockHttpClient.php (55 lines)	-	-
A	M		tests/payload.json (40 lines)	-	-
A	M		tests/response.json (92 lines)	-	-

Diff 1602

.arcconfig

Loading...

.arclint

Loading...

.gitignore

Loading...

CHANGELOG.md

Loading...

README.md

Loading...

composer.json

Loading...

phpunit.xml

Loading...

src/MailgunMessage.php

Loading...

src/MailgunMessageFactory.php

Loading...

tests/MailgunMessageFactoryTest.php

Loading...

tests/MailgunMessageTest.php

Loading...

tests/WithMockHttpClient.php

Loading...

tests/payload.json

Loading...

tests/response.json

Loading...