Differential D641

Accept mail notifications for DockerHub build failures
ClosedPublic
Actions

Authored by dereckson on Sep 1 2016, 19:30.

Tags

None

Referenced Files

	F2826169: D641.id1604.diff
	Thu, Apr 18, 19:07

	Unknown Object (File)
	Sun, Apr 14, 22:45

	Unknown Object (File)
	Sun, Apr 14, 22:07

	Unknown Object (File)
	Sun, Apr 14, 06:46

	Unknown Object (File)
	Sat, Apr 13, 05:42

	Unknown Object (File)
	Tue, Apr 9, 13:12

	Unknown Object (File)
	Tue, Apr 9, 12:41

	Unknown Object (File)
	Mon, Apr 8, 09:52

Subscribers

Details

Reviewers: None
Maniphest Tasks: T1000: Detect builds issues with Docker images
Commits: rNOTIFa5708c2a2662: Accept mail notifications for DockerHub build failures

Summary

The Docker Hub has currently an API to fire webhooks event when the
notification fails, but no mechanism to fire such notification when
a build fails.

But such notifications exist, by mail. We so accept incoming mail
Mailgun payloads to process them and fire a DockerHub buildFailure
notification.

Fixes T1000.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

DockerHubFailures

Unit TestsBroken
View All

	Time	Test
	0 ms	Unknown Unit Message ("") PHP Fatal error: Class 'Nasqueron\Notifications\Notifications\Mailgun' not found in /home/ubuntu/workspace/notifications/app/Notifications/DockerHubNotification.php on line 104 Fatal error: Class 'Nasqueron\Notifications\Notifications\Mailgun' not found in /home/ubuntu/workspace/notifications/app/Notifications/DockerHubNotification.php on line 104 PHP Fatal error: Uncaught exception 'Illuminate\Contracts\Container\BindingResolutionException' with message 'Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable.' in /home/ubuntu/workspace/notifications/vendor/laravel/framework/src/Illuminate/Container/Container.php:748
	217 ms	Unknown Unit Message ("")

Event Timeline

dereckson updated this revision to Diff 1604.Sep 1 2016, 19:30

dereckson retitled this revision from to Accept mail notifications for DockerHub build failures.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a task: T1000: Detect builds issues with Docker images.

dereckson added a subscriber: Sandlayth.

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/190/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/190/console

dereckson added a parent revision: D640: Add Mailgun support.Sep 1 2016, 19:39

Use Mailgun facade defined in D640.

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/191/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/191/console

Extract URL and link from text, tests are ok now.

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/192/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/192/console

Rebased.

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/196/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/196/console

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/199/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/199/console

dereckson planned changes to this revision.Sep 2 2016, 16:09

dereckson added inline comments.

app/Notifications/DockerHubNotification.php
120	Use two classes instead here.

Each DockerHub payload have its own analyzer class.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/205/ for more details.

dereckson planned changes to this revision.Sep 2 2016, 20:12

dereckson marked an inline comment as done.

dereckson added inline comments.

app/Analyzers/DockerHub/BaseEvent.php
5 ↗	(On Diff #1624)	Double space.

Double space → single space in class declarations.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/206/ for more details.

Closed by commit rNOTIFa5708c2a2662: Accept mail notifications for DockerHub build failures (authored by dereckson, committed by Sandlayth). · Explain WhySep 2 2016, 20:47

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Events/

DockerHubPayloadEvent.php

17 lines

Notifications/

DockerHubNotification.php

71 lines

tests/

Notifications/

DockerHubNotificationTest.php

52 lines

data/

payloads/

DockerHubBuildFailurePayload.json

40 lines

Diff 1604

app/Events/DockerHubPayloadEvent.php

Loading...

app/Notifications/DockerHubNotification.php

Loading...

tests/Notifications/DockerHubNotificationTest.php

Loading...

tests/data/payloads/DockerHubBuildFailurePayload.json

Loading...