Page MenuHomeDevCentral
Differential D645

Composer: don't run php artisan optimize before a build
ClosedPublic
Actions

Authored by dereckson on Sep 2 2016, 14:31.
Tags
Referenced Files
F37602268: D645.id.diff
Tue, Jul 21, 11:37
F37599319: D645.id.diff
Tue, Jul 21, 11:14
F37550693: D645.id1618.diff
Tue, Jul 21, 04:22
F37550528: D645.id1619.diff
Tue, Jul 21, 04:21
F37545282: D645.diff
Tue, Jul 21, 03:39
Unknown Object (File)
Sun, Jul 19, 23:02
Unknown Object (File)
Sat, Jul 4, 08:02
Unknown Object (File)
Sat, Jul 4, 04:46
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1003: Improve Ant build file
Commits
rNOTIF77798fdd6c2d: Composer: don't run php artisan optimize before a build
Summary

Cases where php artisan optimize is needed, especially when opcache
is enabled on production servers are limited enough to be a choice to
made by each deployment, not automatically done.

We so remove these step from composer install/update.

For CI purpose, that will speed up builds, ref T1003.

Test Plan

Run a build on CI infrastructure.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1618.Sep 2 2016, 14:31
dereckson retitled this revision from to Composer: don't run php artisan optimize before a build.
dereckson updated this object.
dereckson added a reviewer: dereckson.
dereckson accepted this revision.Sep 2 2016, 14:33
dereckson edited edge metadata.
This revision is now accepted and ready to land.Sep 2 2016, 14:33
alken-orin added a subscriber: alken-orin.Sep 2 2016, 14:37

Build is green https://ci.nasqueron.org/job/test-notifications-phab/202/ for more details.

dereckson updated this object.Sep 2 2016, 14:37
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.
dereckson added a project: Continous integration and delivery.
dereckson added a task: T1003: Improve Ant build file.
dereckson removed a subscriber: alken-orin.
Closed by commit rNOTIF77798fdd6c2d: Composer: don't run php artisan optimize before a build (authored by dereckson, committed by dereckson). · Explain WhySep 2 2016, 14:50
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
7 lines

Diff 1619

View Options

composer.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator