Improve Ant build file
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dereckson
	Sep 2 2016, 12:06

Description

Some suggested changes for Ant build.xml:

we MUST run composer update: if new dependencies are added, we NEED them
try to run in // the static analysis tools: we've several cores on the servers
we don't need documentation for -phab Jenkins job, only for full-build (-php), but we still need unit test code coverage (we wouldn't if Phabricator would be more greedy for coverage)

Revisions and Commits

rNOTIF Notifications center
	D645	rNOTIF77798fdd6c2d Composer: don't run php artisan optimize before a build
	D644	rNOTIF06c8bfa21e44 CI: composer update, allow code review builds to skip documentation

Event Timeline

dereckson created this task.Sep 2 2016, 12:06

dereckson added a revision: D644: CI: composer update, allow code review builds to skip documentation.Sep 2 2016, 12:09

On CI container slaves, I suggest, we disable XDebug by default, and wrap phpunit to use a configuration file with XDebug:

Remove PHPUnit symlink and XDebug config

$ mv /usr/local/etc/php/conf.d/xdebug.ini /opt/php-xdebug.ini
$ rm /usr/local/bin/phpunit
$ cat > /usr/local/bin/phpunit
[…]
$ chmod +x /usr/local/bin/phpunit

/usr/local/bin/phpunit

#!/bin/sh
php -c /opt/php-xdebug.ini /opt/phpunit.phar $@

So everything will run without XDebug, excepted PHPUnit.

/usr/local/bin/phpunit

#!/usr/bin/env bash
if [[ "$@" =~ "--no-coverage" ]]; then
        OPTS=""
else
        OPTS="-c /opt/php-xdebug.ini"
fi
php $OPTS /opt/phpunit.phar $@

dereckson added a commit: rNOTIF06c8bfa21e44: CI: composer update, allow code review builds to skip documentation.Sep 2 2016, 14:14

dereckson added a revision: D645: Composer: don't run php artisan optimize before a build.Sep 2 2016, 14:38

dereckson added a commit: rNOTIF77798fdd6c2d: Composer: don't run php artisan optimize before a build.Sep 2 2016, 14:50

dereckson closed this task as Resolved.Sep 2 2016, 14:56

Improve Ant build fileClosed, ResolvedPublicActions

Description

Revisions and Commits

Event Timeline

Improve Ant build file
Closed, ResolvedPublic
Actions