Set mock methods as static
ClosedPublic
Actions

Authored by dereckson on Sep 3 2016, 00:35.

Tags

None

Referenced Files

	F3717123: D649.diff
	Wed, Nov 6, 01:29

	Unknown Object (File)
	Sat, Oct 26, 02:16

	Unknown Object (File)
	Sun, Oct 20, 00:40

	Unknown Object (File)
	Wed, Oct 16, 05:20

	Unknown Object (File)
	Wed, Oct 16, 05:20

	Unknown Object (File)
	Wed, Oct 16, 05:09

	Unknown Object (File)
	Wed, Oct 16, 04:59

	Unknown Object (File)
	Mon, Oct 14, 15:44

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKDOCKERHUBe3d74d63aa43: Set mock methods as static

Summary

The mock for the HTTP client doesn't use any class member,
so can be static.

A default value of 200 is also set by default.

Test Plan

Ensure tests (this and D650) still run.

Diff Detail

Repository

rKDOCKERHUB Keruald Docker Hub

Lint

Lint Passed

Unit

Tests Passed

Branch

master

Build Status

Buildable 992
Build 1197: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 1635.Sep 3 2016, 00:35

dereckson retitled this revision from to Set mock methods as static.

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Sep 3 2016, 00:36

dereckson edited edge metadata.

This revision is now accepted and ready to land.Sep 3 2016, 00:36

dereckson updated this object.Sep 3 2016, 00:37

dereckson edited the test plan for this revision. (Show Details)

dereckson edited edge metadata.

Closed by commit rKDOCKERHUBe3d74d63aa43: Set mock methods as static (authored by dereckson, committed by dereckson). · Explain WhySep 3 2016, 00:38

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

tests/

DockerHubImageTest.php

2 lines

WithMockHttpClient.php

2 lines

Diff 1635

View Options

tests/DockerHubImageTest.php