Page MenuHomeDevCentral
Differential D686

Handle issue_comment event on GitHub
ClosedPublic
Actions

Authored by dereckson on Oct 19 2016, 20:18.
Tags
None
Referenced Files
F10824372: D686.diff
Sun, Jul 27, 23:31
F10824003: D686.id1725.diff
Sun, Jul 27, 23:01
Unknown Object (File)
Mon, Jul 21, 03:43
Unknown Object (File)
Mon, Jul 21, 03:43
Unknown Object (File)
Mon, Jul 21, 03:43
Unknown Object (File)
Mon, Jul 21, 01:04
Unknown Object (File)
Sat, Jul 19, 02:02
Unknown Object (File)
Fri, Jul 18, 23:14
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Maniphest Tasks
T844: Handle GitHub issue_comment event
Commits
rNOTIF08e1e5ca8189: Handle issue_comment event on GitHub
Summary

Reference: https://developer.github.com/v3/activity/events/types/#issuecommentevent

Fixes T844.

Test Plan

Unit tests have been added for this new event,
with sample payload from GiHub API documentation.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 1723.Oct 19 2016, 20:18
dereckson retitled this revision from to Handle issue_comment event on GitHub.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson added a task: T844: Handle GitHub issue_comment event.
alken-orin added a subscriber: alken-orin.Oct 19 2016, 20:21

Build is green https://ci.nasqueron.org/job/test-notifications-phab/216/ for more details.

dereckson updated this revision to Diff 1724.Oct 19 2016, 21:41
dereckson edited edge metadata.

Dots

dereckson accepted this revision.Oct 19 2016, 21:41
dereckson edited edge metadata.
This revision is now accepted and ready to land.Oct 19 2016, 21:41
alken-orin added a comment.Oct 19 2016, 21:44

Build is green https://ci.nasqueron.org/job/test-notifications-phab/217/ for more details.

Closed by commit rNOTIF08e1e5ca8189: Handle issue_comment event on GitHub (authored by dereckson, committed by dereckson). · Explain WhyOct 19 2016, 23:46
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Analyzers/
GitHub/
Events/
65 lines
resources/
lang/
en/
7 lines
tests/
Analyzers/
GitHub/
Events/
5 lines
44 lines
data/
payloads/
GitHubEvents/
182 lines

Diff 1725

View Options

app/Analyzers/GitHub/Events/IssueCommentEvent.php

Loading...
View Options

resources/lang/en/GitHub.php

Loading...
View Options

tests/Analyzers/GitHub/Events/EventTest.php

Loading...
View Options

tests/Analyzers/GitHub/Events/IssueCommentEventTest.php

Loading...
View Options

tests/data/payloads/GitHubEvents/issue_comment.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator