Page MenuHomeDevCentral

Honour Application abstract contract in ReportServiceProvider
ClosedPublic

Authored by dereckson on Dec 28 2016, 03:45.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 19:58
Unknown Object (File)
Mon, Apr 22, 18:00
Unknown Object (File)
Sun, Apr 21, 09:54
Unknown Object (File)
Fri, Apr 19, 01:06
Unknown Object (File)
Thu, Apr 18, 20:08
Unknown Object (File)
Mon, Apr 15, 05:29
Unknown Object (File)
Sun, Apr 14, 22:02
Unknown Object (File)
Sun, Apr 14, 02:58
Subscribers

Details

Summary

Laravel Container and so Application classes offer to access services:

  • using the make method in the abstract contract
  • through ArrayAccess in the concrete implementation

We used array access, but documented ReportServiceProvider::register
is happy to accept any \Illuminate\Contracts\Foundation\Application.

To honour this claim, we so switch to use the make method.

This is a follow-up to 6ed92b9a75b8.

This fixes the following phan issue:

app/Providers/ReportServiceProvider.php:21
PhanTypeArraySuspicious
Suspicious array access to \Illuminate\Contracts\Foundation\Application
Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 11:26
This revision was automatically updated to reflect the committed changes.