Page MenuHomeDevCentral

Honour Application abstract contract in ReportServiceProvider
ClosedPublic

Authored by dereckson on Dec 28 2016, 03:45.
Tags
None
Referenced Files
F57019297: D771.diff
Fri, Nov 13, 00:43
F56925768: D771.id1951.diff
Tue, Nov 10, 23:30
F56925766: D771.id1952.diff
Tue, Nov 10, 23:30
F56925764: D771.id.diff
Tue, Nov 10, 23:30
F56651226: D771.id1951.diff
Sun, Nov 8, 00:18
F56449904: D771.id.diff
Fri, Nov 6, 06:50
F55929208: D771.id1952.diff
Sun, Nov 1, 14:14
Unknown Object (File)
Sun, Oct 25, 09:15
Subscribers

Details

Summary

Laravel Container and so Application classes offer to access services:

  • using the make method in the abstract contract
  • through ArrayAccess in the concrete implementation

We used array access, but documented ReportServiceProvider::register
is happy to accept any \Illuminate\Contracts\Foundation\Application.

To honour this claim, we so switch to use the make method.

This is a follow-up to 6ed92b9a75b8.

This fixes the following phan issue:

app/Providers/ReportServiceProvider.php:21
PhanTypeArraySuspicious
Suspicious array access to \Illuminate\Contracts\Foundation\Application
Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 11:26
This revision was automatically updated to reflect the committed changes.