Page MenuHomeDevCentral

Honour Application abstract contract in ReportServiceProvider
ClosedPublic

Authored by dereckson on Dec 28 2016, 03:45.
Tags
None
Referenced Files
F3161611: D771.id1951.diff
Wed, Jun 26, 07:26
F3161522: D771.id1952.diff
Wed, Jun 26, 07:12
F3158924: D771.diff
Wed, Jun 26, 01:01
Unknown Object (File)
Tue, Jun 25, 02:51
Unknown Object (File)
Mon, Jun 24, 06:11
Unknown Object (File)
Sun, Jun 23, 21:42
Unknown Object (File)
Thu, Jun 20, 18:17
Unknown Object (File)
Mon, Jun 17, 03:01
Subscribers

Details

Summary

Laravel Container and so Application classes offer to access services:

  • using the make method in the abstract contract
  • through ArrayAccess in the concrete implementation

We used array access, but documented ReportServiceProvider::register
is happy to accept any \Illuminate\Contracts\Foundation\Application.

To honour this claim, we so switch to use the make method.

This is a follow-up to 6ed92b9a75b8.

This fixes the following phan issue:

app/Providers/ReportServiceProvider.php:21
PhanTypeArraySuspicious
Suspicious array access to \Illuminate\Contracts\Foundation\Application
Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
suspicious-array-access (branched from master)

Event Timeline

dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 28 2016, 11:26
This revision was automatically updated to reflect the committed changes.