Page MenuHomeDevCentral

Improve code guidelines for exception handler
ClosedPublic

Authored by dereckson on Dec 31 2016, 20:56.
Tags
None
Referenced Files
F3163339: D783.diff
Wed, Jun 26, 11:23
F3160779: D783.id1981.diff
Wed, Jun 26, 05:19
F3160776: D783.id1980.diff
Wed, Jun 26, 05:19
F3159960: D783.id.diff
Wed, Jun 26, 03:14
F3159704: D783.diff
Wed, Jun 26, 02:42
F3155105: D783.diff
Tue, Jun 25, 13:04
Unknown Object (File)
Mon, Jun 24, 23:50
Unknown Object (File)
Mon, Jun 24, 12:16
Subscribers

Details

Summary

The class had still the autogenerated style of Laravel
instead to use our code base guidelines:

Quick cleanup:

  • Drop a method only calling parent method
  • Sort by alphabetical and logic order use clauses
  • Add PHP 7 return types
  • Document more richly arrays as type[]
  • Respect Nasqueron code style:
    • Comments are 3rd person
    • Brackets on the same line
Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson edited the summary of this revision. (Show Details)
dereckson edited edge metadata.
This revision is now accepted and ready to land.Dec 31 2016, 21:00
This revision was automatically updated to reflect the committed changes.