Page MenuHomeDevCentral
Differential D790

Refactor command:show to use ConfigReport
ClosedPublic
Actions

Authored by dereckson on Jan 1 2017, 04:44.
Tags
None
Referenced Files
F3911581: D790.diff
Thu, Dec 19, 03:17
Unknown Object (File)
Tue, Dec 17, 13:10
Unknown Object (File)
Mon, Dec 16, 22:22
Unknown Object (File)
Sun, Dec 15, 03:24
Unknown Object (File)
Sun, Dec 15, 03:24
Unknown Object (File)
Sun, Dec 15, 03:24
Unknown Object (File)
Sun, Dec 15, 03:24
Unknown Object (File)
Sun, Dec 15, 03:24
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1066: Report current configuration state
Commits
rNOTIFb99ae64827ee: Refactor command:show to use ConfigReport
Summary

This is a follow-up for f3fcf394ac9c.

Ref T1066.

Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Test Failures
Branch
refactor-command-config-show (branched from master)
Build Status
Buildable 1209
Build 1457: arc lint + arc unit

Unit TestsBroken
View All

TimeTest
66 msUnknown Unit Message ("")
Can't reach Phabricator API endpoint: https://phabricator.acme.tld/api/project.query /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:155 /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:96
10 msUnknown Unit Message ("")
Can't reach Phabricator API endpoint: https://phabricator.acme.tld/api/project.query /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:155 /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:96
9 msUnknown Unit Message ("")
Can't reach Phabricator API endpoint: https://phabricator.acme.tld/api/project.query /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:155 /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:96
10 msUnknown Unit Message ("")
Can't reach Phabricator API endpoint: https://phabricator.acme.tld/api/project.query /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:155 /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:96
12 msUnknown Unit Message ("")
Can't reach Phabricator API endpoint: https://phabricator.acme.tld/api/project.query /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:155 /home/ubuntu/workspace/notifications/app/Phabricator/PhabricatorAPI.php:96

Event Timeline

dereckson created this revision.Jan 1 2017, 04:44
dereckson updated this revision to Diff 2010.Jan 3 2017, 00:21
dereckson edited edge metadata.

BaseReportEntry helper static methods

dereckson updated this revision to Diff 2011.Jan 3 2017, 00:38

More tests for Nasqueron\Notifications\Tests\Config\Reporting classes

dereckson planned changes to this revision.Jan 3 2017, 00:41
dereckson updated this revision to Diff 2012.Jan 3 2017, 02:15

Don't run logic in command constructor, we need to mock services in container before.

dereckson planned changes to this revision.Jan 3 2017, 02:20
dereckson added inline comments.
app/Console/Commands/ConfigShow.php
8

Unused

tests/Config/Reporting/ServiceReportEntryTest.php
36 ↗(On Diff #2012)

Fill this or drop the test (we already test that through config:show test).

dereckson updated this revision to Diff 2013.Jan 3 2017, 02:24
dereckson marked 2 inline comments as done.

Prune unused code

dereckson accepted this revision.Jan 3 2017, 02:25
This revision is now accepted and ready to land.Jan 3 2017, 02:25
Closed by commit rNOTIFb99ae64827ee: Refactor command:show to use ConfigReport (authored by dereckson, committed by dereckson). · Explain WhyJan 3 2017, 02:25
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Config/
Reporting/
28 lines
32 lines
Console/
Commands/
58 lines

Diff 1998

View Options

app/Config/Reporting/FeatureReportEntry.php

Loading...
View Options

app/Config/Reporting/ServiceReportEntry.php

Loading...
View Options

app/Console/Commands/ConfigShow.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator