Page MenuHomeDevCentral

Adding Numerama
ClosedPublic

Authored by Thibaut120094 on Jan 5 2017, 19:04.

Diff Detail

Repository
rSTG Source templates generator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Thibaut120094 created this revision.Jan 5 2017, 19:04

Woops, arc didn't include the php file, retrying... Sorry.

Thibaut120094 updated this revision to Diff 2027.Jan 5 2017, 19:10

Adding numerama.php

dereckson updated this revision to Diff 2029.Jan 5 2017, 20:55
dereckson edited edge metadata.

Rebased against e6a0661

Testing on tools51.

dereckson requested changes to this revision.Jan 5 2017, 21:13

Currently live on https://tools51.nasqueron.org/wikimedia/write/sourcetemplatesgenerator/ ­— works well:

{{Lien web
 | auteur = Julien Cadot
 | titre = Ce n'est pas une blague : Microsoft vient de rejoindre la Linux Foundation - Tech - Numerama
 | jour = 16
 | mois = novembre
 | année = 2016
 | url = http://www.numerama.com/tech/209271-microsoft-vient-de-rejoindre-la-linux-foundation.html
 | site = [[Numerama]]
 | consulté le = 5 janvier 2017
}}
pages/numerama.php
7

Works without through curl too, Numerama doesn't protect the site against automated clients, so this trait isn't needed.

22

We can directly use $this->meta_tags['author']: case is sensible and right.

The name_case function allows to rewrite names in caps in a more traditional case.

This revision now requires changes to proceed.Jan 5 2017, 21:13
Thibaut120094 updated this revision to Diff 2031.Jan 5 2017, 23:00
Thibaut120094 edited edge metadata.
  • Minor changes after Dereckson's comments (thank you!)
dereckson accepted this revision.Jan 6 2017, 03:29
This revision is now accepted and ready to land.Jan 6 2017, 03:29
dereckson added inline comments.Jan 6 2017, 03:31
pages/numerama.php
20

$this->author

dereckson updated this revision to Diff 2033.Jan 6 2017, 03:33

$this->author

This revision was automatically updated to reflect the committed changes.