Fix type issue in XHubSignature::parseSignature
ClosedPublic
Actions

Authored by dereckson on Jan 7 2017, 06:11.

Tags

None

Referenced Files

	F3304573: D805.diff
	Wed, Jul 3, 09:30

	F3302510: D805.id2040.diff
	Wed, Jul 3, 00:13

	Unknown Object (File)
	Fri, Jun 28, 18:11

	Unknown Object (File)
	Thu, Jun 27, 13:24

	Unknown Object (File)
	Wed, Jun 26, 17:15

	Unknown Object (File)
	Wed, Jun 26, 17:15

	Unknown Object (File)
	Wed, Jun 26, 17:02

	Unknown Object (File)
	Wed, Jun 26, 16:48

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKGHc0e14492852e: Fix type issue in XHubSignature::parseSignature

Summary

This fixes the following issue:

Type error: Return value of
Nasqueron\Notifications\Http\Controllers\Gate\GitHubGateController::getSignature()
must be of the type string, null returned in
/src/app/Http/Controllers/Gate/GitHubGateController.php:114

Diff Detail

Repository

rKGH Keruald GitHub

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

type (branched from master)

Build Status

Buildable 1235
Build 1483: arc lint + arc unit

Event Timeline

dereckson created this revision.Jan 7 2017, 06:11

Harbormaster completed remote builds in B1235: Diff 2040.Jan 7 2017, 06:11

dereckson accepted this revision.Jan 7 2017, 06:12

dereckson added a parent revision: D804: Declare explicitely types.

This revision is now accepted and ready to land.Jan 7 2017, 06:13

Closed by commit rKGHc0e14492852e: Fix type issue in XHubSignature::parseSignature (authored by dereckson, committed by dereckson). · Explain WhyJan 7 2017, 06:15

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

XHubSignature.php

4 lines

Diff 2040

View Options

Fix type issue in XHubSignature::parseSignatureClosedPublicActions