Page MenuHomeDevCentral

Remove GitHub to AMQP mirror feature
ClosedPublic

Authored by dereckson on Jan 8 2017, 02:24.
Tags
None
Referenced Files
F3716600: D808.diff
Tue, Nov 5, 16:32
Unknown Object (File)
Thu, Oct 31, 14:29
Unknown Object (File)
Thu, Oct 31, 00:52
Unknown Object (File)
Tue, Oct 22, 02:42
Unknown Object (File)
Sun, Oct 13, 05:23
Unknown Object (File)
Sun, Oct 13, 00:05
Unknown Object (File)
Sat, Oct 12, 11:09
Unknown Object (File)
Fri, Oct 11, 06:02
Subscribers
None

Details

Summary

Before the notifications system, we introduced a direct GitHub to AMQP broker
gateway at 7e5bd3c8b.

This system helped to implement the broker aspects, but was then superseded
by our standard notifications format.

As we strive to simplify the events propagation to ease to add more services,
and as nobody seems to use it, we remove this legacy feature.

Test Plan

Run tests. No unit test covered the feature.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
kill-github-broker-mirror (branched from master)
Build Status
Buildable 1241
Build 1489: arc lint + arc unit

Event Timeline

dereckson edited edge metadata.

Change touches code style too.

This revision is now accepted and ready to land.Jan 8 2017, 03:39
This revision was automatically updated to reflect the committed changes.