Page MenuHomeDevCentral
Differential D871

Accept notifications in our native format
ClosedPublic
Actions

Authored by dereckson on Jan 27 2017, 23:40.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 13:16
Unknown Object (File)
Sun, Dec 15, 16:11
Unknown Object (File)
Sat, Dec 14, 05:17
Unknown Object (File)
Fri, Dec 13, 23:56
Unknown Object (File)
Thu, Dec 12, 14:50
Unknown Object (File)
Wed, Dec 11, 21:53
Unknown Object (File)
Wed, Dec 11, 21:39
Unknown Object (File)
Wed, Dec 11, 06:55
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T979: Gate for notifications in notifications format
Commits
rNOTIFbff16342f354: Accept notifications in our native format
Summary

Gate to receive notifications already in our format.

Fixes T979.

Test Plan

Fire a notification

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.Jan 27 2017, 23:40
dereckson updated this revision to Diff 2270.Jan 30 2017, 20:06
dereckson edited edge metadata.

Controller draft

dereckson updated this revision to Diff 2274.Jan 31 2017, 01:36

getServiceName should currently be protected

Harbormaster completed remote builds in B1382: Diff 2274.Jan 31 2017, 01:36
dereckson updated this revision to Diff 2275.Jan 31 2017, 01:37

Rebased

dereckson retitled this revision from WIP: Notifications gate to Accept notifications in our native format.Jan 31 2017, 01:44
dereckson updated this revision to Diff 2278.Jan 31 2017, 02:06

Cast service as a string

dereckson added a task: T979: Gate for notifications in notifications format.Jan 31 2017, 02:08
dereckson mentioned this in D897: Allow a gate to accept payloads for several services.Jan 31 2017, 02:12
dereckson mentioned this in rNOTIFf894aafec195: Allow a gate to accept payloads for several services.Jan 31 2017, 02:24
dereckson updated this revision to Diff 2282.Jan 31 2017, 02:25

Rebased

dereckson edited the summary of this revision. (Show Details)Jan 31 2017, 02:27
dereckson planned changes to this revision.EditedJan 31 2017, 02:29

We need to add minimal checks, because {} payload currently produce a valid notification.

[01:50:16] <None/None> None

{ project: "Nasqueron" } payload produces:
[02:33:32] <Nasqueron/None> None
02:33:33 <Wearg> [DEBUG] Message for unknown group: Nasqueron null

An exception is thrown for Invalid JSON or when the raw payload is a string.

dereckson added a comment.Jan 31 2017, 17:26

By the way, payloads MUST be protected, at least by an API key, or using the GitHub system.

If not, this a free party flood.

dereckson added a comment.Jan 31 2017, 21:23
In D871#13499, @dereckson wrote:

We need to add minimal checks, because {} payload currently produce a valid notification.

[01:50:16] <None/None> None

{ project: "Nasqueron" } payload produces:
[02:33:32] <Nasqueron/None> None
02:33:33 <Wearg> [DEBUG] Message for unknown group: Nasqueron null

An exception is thrown for Invalid JSON or when the raw payload is a string.

Done, will return a HTTP 400 Bad request code.

dereckson updated this revision to Diff 2287.Jan 31 2017, 21:24

Validation, whitespace

dereckson planned changes to this revision.Jan 31 2017, 22:43
dereckson added inline comments.
app/Http/Controllers/Gate/GateController.php
124 ↗(On Diff #2287)

Hu? This method seems an artefact left while preparing D897.

dereckson updated this revision to Diff 2288.Jan 31 2017, 22:45
dereckson marked an inline comment as done.

Remove GateController::getServiceName

dereckson mentioned this in T1078: Allow external tools to publish server admin log entries.Jan 31 2017, 23:04
dereckson accepted this revision.EditedJan 31 2017, 23:39
In D871#13501, @dereckson wrote:

By the way, payloads MUST be protected, at least by an API key, or using the GitHub system.

If not, this a free party flood.

This is a more generic problem to solve, just filled as T1147.

This revision is now accepted and ready to land.Jan 31 2017, 23:39
Closed by commit rNOTIFbff16342f354: Accept notifications in our native format (authored by dereckson, committed by dereckson). · Explain WhyJan 31 2017, 23:41
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
app/
Http/
Controllers/
Gate/
139 lines
config/
4 lines
tests/
data/
1 line

Diff 2289

View Options

app/Http/Controllers/Gate/NotificationGateController.php

Loading...
View Options

config/gate.php

Loading...
View Options

tests/data/config.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator