Page MenuHomeDevCentral

Fix null exception when Phabricator repository is private
ClosedPublic

Authored by dereckson on Jan 28 2017, 00:01.
Tags
None
Referenced Files
F3782999: D872.id2216.diff
Tue, Nov 26, 01:43
F3782998: D872.id2215.diff
Tue, Nov 26, 01:43
Unknown Object (File)
Fri, Nov 8, 18:15
Unknown Object (File)
Oct 26 2024, 17:05
Unknown Object (File)
Oct 26 2024, 07:38
Unknown Object (File)
Oct 22 2024, 02:43
Unknown Object (File)
Oct 21 2024, 21:32
Unknown Object (File)
Oct 17 2024, 07:18
Subscribers
None

Details

Summary

When a repository is private and can't be reached by the bot account
used to fetch Phabricator information, a null exception occurs in
PhabricatorStory::getRepositoryPHID method.

This change handles the case an API query doesn't contain the
required information.

Fixes T1136.

Test Plan

Fire again the notification.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 28 2017, 00:02
This revision was automatically updated to reflect the committed changes.