Page MenuHomeDevCentral

Fix null exception when Phabricator repository is private
ClosedPublic

Authored by dereckson on Jan 28 2017, 00:01.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 31, 15:05
Unknown Object (File)
Wed, May 14, 22:03
Unknown Object (File)
Wed, May 14, 22:02
Unknown Object (File)
Tue, May 13, 00:07
Unknown Object (File)
Mon, May 12, 20:45
Unknown Object (File)
Mon, May 12, 06:58
Unknown Object (File)
Mon, May 12, 06:39
Unknown Object (File)
Sun, May 11, 20:36
Subscribers
None

Details

Summary

When a repository is private and can't be reached by the bot account
used to fetch Phabricator information, a null exception occurs in
PhabricatorStory::getRepositoryPHID method.

This change handles the case an API query doesn't contain the
required information.

Fixes T1136.

Test Plan

Fire again the notification.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
T1136 (branched from master)
Build Status
Buildable 1346
Build 1594: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jan 28 2017, 00:02
This revision was automatically updated to reflect the committed changes.