Fix null exception when Phabricator object is private
ClosedPublic
Actions

Authored by dereckson on Jan 28 2017, 00:17.

Details

Reviewers

Maniphest Tasks

T1138: Null exception in PhabricatorStory::getItemProjectsPHIDsThroughApplicationSearch() when notifications user account doesn't have an access to a paste

Commits

rNOTIFb7daa4cc8137: Fix null exception when Phabricator object is private

Summary

When an object like a paste is private and can't be reached by the bot
account used to fetch Phabricator information, a null exception occurs
in PhabricatorStory::getItemProjectsPHIDsThroughApplicationSearch().

This change handles the case an API query doesn't contain the
required information.

Fixes T1138.

Test Plan

Fire again the notification.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

No Test Coverage

Branch

T1138

Build Status

Buildable 1347
Build 1595: arc lint + arc unit

Event Timeline

dereckson created this revision.Jan 28 2017, 00:17

Harbormaster completed remote builds in B1347: Diff 2217.Jan 28 2017, 00:17

dereckson accepted this revision.Jan 28 2017, 00:17

dereckson edited the test plan for this revision. (Show Details)

This revision is now accepted and ready to land.Jan 28 2017, 00:17

Closed by commit rNOTIFb7daa4cc8137: Fix null exception when Phabricator object is private (authored by dereckson, committed by dereckson). · Explain WhyJan 28 2017, 00:18

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Phabricator/

PhabricatorStory.php

11 lines

Diff 2217

View Options

app/Phabricator/PhabricatorStory.php

Fix null exception when Phabricator object is privateClosedPublicActions