Page MenuHomeDevCentral

Improve login
ClosedPublic

Authored by dereckson on Jan 29 2017, 22:04.
Tags
None
Referenced Files
F12789215: D883.id2244.diff
Fri, Nov 14, 23:49
F12788817: D883.id.diff
Fri, Nov 14, 23:45
F12788641: D883.diff
Fri, Nov 14, 23:43
Unknown Object (File)
Fri, Nov 14, 03:26
Unknown Object (File)
Sun, Nov 2, 16:58
Unknown Object (File)
Sat, Nov 1, 23:44
Unknown Object (File)
Wed, Oct 29, 02:30
Unknown Object (File)
Tue, Oct 28, 07:21
Subscribers
None

Details

Summary

Improve login code

Notify when the pass has been recognized, but not for a channel
the user is.

Improve verify_pass code style:

  • avoid useless explicit cast, as variable is already this type
  • avoid assignation in if clause
  • extract complex condition in has_access_for_this_channel()
Test Plan

Create an access #anotherchan in userlist.db

Then try to login:

18:25:09 <Dereckson> login ...
18:25:09 -Ephemereal- Pass verified but access is only for #anotherchan.

Diff Detail

Repository
rDARKBOT Darkbot
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson added inline comments.
source/helpers.c
268

This violates single responsibility, it verifies, and it notifies.

This revision is now accepted and ready to land.Jan 29 2017, 22:06
This revision was automatically updated to reflect the committed changes.