Page MenuHomeDevCentral

Improve login
ClosedPublic

Authored by dereckson on Jan 29 2017, 22:04.
Tags
None
Referenced Files
F3770297: D883.diff
Sat, Nov 23, 19:44
F3767054: D883.diff
Fri, Nov 22, 22:08
Unknown Object (File)
Thu, Nov 14, 03:43
Unknown Object (File)
Tue, Nov 12, 22:42
Unknown Object (File)
Fri, Nov 8, 00:25
Unknown Object (File)
Fri, Nov 8, 00:24
Unknown Object (File)
Fri, Nov 8, 00:07
Unknown Object (File)
Thu, Nov 7, 23:47
Subscribers
None

Details

Summary

Improve login code

Notify when the pass has been recognized, but not for a channel
the user is.

Improve verify_pass code style:

  • avoid useless explicit cast, as variable is already this type
  • avoid assignation in if clause
  • extract complex condition in has_access_for_this_channel()
Test Plan

Create an access #anotherchan in userlist.db

Then try to login:

18:25:09 <Dereckson> login ...
18:25:09 -Ephemereal- Pass verified but access is only for #anotherchan.

Diff Detail

Repository
rDARKBOT Darkbot
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
debug-login (branched from master)
Build Status
Buildable 1362
Build 1610: arc lint + arc unit

Event Timeline

dereckson added inline comments.
source/helpers.c
268

This violates single responsibility, it verifies, and it notifies.

This revision is now accepted and ready to land.Jan 29 2017, 22:06
This revision was automatically updated to reflect the committed changes.