Page MenuHomeDevCentral

Improve login
ClosedPublic

Authored by dereckson on Jan 29 2017, 22:04.
Tags
None
Referenced Files
F21085705: D883.diff
Thu, Jan 15, 07:24
F21079332: D883.id2243.diff
Thu, Jan 15, 05:35
F21064776: D883.id2243.diff
Thu, Jan 15, 01:37
Unknown Object (File)
Fri, Jan 9, 13:54
Unknown Object (File)
Sun, Dec 28, 22:46
Unknown Object (File)
Sun, Dec 28, 22:46
Unknown Object (File)
Sun, Dec 28, 21:01
Unknown Object (File)
Wed, Dec 24, 16:53
Subscribers
None

Details

Summary

Improve login code

Notify when the pass has been recognized, but not for a channel
the user is.

Improve verify_pass code style:

  • avoid useless explicit cast, as variable is already this type
  • avoid assignation in if clause
  • extract complex condition in has_access_for_this_channel()
Test Plan

Create an access #anotherchan in userlist.db

Then try to login:

18:25:09 <Dereckson> login ...
18:25:09 -Ephemereal- Pass verified but access is only for #anotherchan.

Diff Detail

Repository
rDARKBOT Darkbot
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
debug-login (branched from master)
Build Status
Buildable 1362
Build 1610: arc lint + arc unit

Event Timeline

dereckson added inline comments.
source/helpers.c
268

This violates single responsibility, it verifies, and it notifies.

This revision is now accepted and ready to land.Jan 29 2017, 22:06
This revision was automatically updated to reflect the committed changes.