Page MenuHomeDevCentral
Differential D885

Fix long incoherence for user levels
ClosedPublic
Actions

Authored by dereckson on Jan 29 2017, 23:04.
Tags
None
Referenced Files
F27015377: D885.id2248.diff
Tue, Apr 28, 14:54
Unknown Object (File)
Fri, Apr 24, 20:58
Unknown Object (File)
Fri, Apr 24, 10:51
Unknown Object (File)
Fri, Apr 24, 03:21
Unknown Object (File)
Wed, Apr 22, 01:26
Unknown Object (File)
Tue, Apr 21, 18:38
Unknown Object (File)
Tue, Apr 21, 04:45
Unknown Object (File)
Mon, Apr 20, 10:33
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rDARKBOTcf2534fee6e3: Fix long incoherence for user levels
Summary

As the user level is declared as a long, we should compare it with
other long values. As such, check_access now returns a long.

Test Plan

Recompile, test level commands

Diff Detail

Repository
rDARKBOT Darkbot
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
long (branched from master)
Build Status
Buildable 1365
Build 1613: arc lint + arc unit

Event Timeline

dereckson created this revision.Jan 29 2017, 23:04
Harbormaster completed remote builds in B1364: Diff 2247.Jan 29 2017, 23:04
dereckson planned changes to this revision.Jan 29 2017, 23:06
dereckson added inline comments.
source/chansrv.c
614–617

Declare at top instead.

dereckson updated this revision to Diff 2248.Jan 29 2017, 23:51
dereckson marked an inline comment as done.
dereckson edited edge metadata.

Initialize at chanserv_help's top

dereckson accepted this revision.Jan 29 2017, 23:56
This revision is now accepted and ready to land.Jan 29 2017, 23:56
Closed by commit rDARKBOTcf2534fee6e3: Fix long incoherence for user levels (authored by dereckson, committed by dereckson). · Explain WhyJan 29 2017, 23:57
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
25 lines
2 lines
4 lines

Diff 2248

View Options

source/chansrv.c

Loading...
View Options

source/helpers.c

Loading...
View Options

source/prototypes.h

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator