Page MenuHomeDevCentral

Bump jsonmapper to v1.1.1
ClosedPublic

Authored by dereckson on Jan 31 2017, 01:26.
Tags
None
Referenced Files
F9449752: D896.id2273.diff
Wed, Jun 4, 18:30
Unknown Object (File)
Tue, Jun 3, 11:27
Unknown Object (File)
Mon, Jun 2, 14:18
Unknown Object (File)
Mon, Jun 2, 00:03
Unknown Object (File)
Sat, May 31, 14:11
Unknown Object (File)
Sat, May 31, 09:36
Unknown Object (File)
Tue, May 13, 04:43
Unknown Object (File)
Fri, May 9, 19:40
Subscribers
None

Details

Summary

Composer installed 0.1.3, as the package version constraint was ~0.1.0.

This version can't correctly handle a property documented as mixed:

Notification
/**
 * The notification's source payload, data or message
 *
 * @var mixed
 */
public $rawContent;

With this version, JsonMapper raises the following issue:

Class '\Nasqueron\Notifications\Notifications\mixed' not found

This is a known bug, fixed upstream:
https://github.com/cweiske/jsonmapper/issues/33

The version is bumped to get this fix.

Test Plan

Run tests to ensure current mappings still work.

Test this code works:

private function getNotification () : Notification {
    $mapper = new \JsonMapper();
    return $mapper->map(
        json_decode($this->rawRequestContent),
        new Notification
    );
}

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
This revision is now accepted and ready to land.Jan 31 2017, 01:34
This revision was automatically updated to reflect the committed changes.