Page MenuHomeDevCentral

Bump jsonmapper to v1.1.1
ClosedPublic

Authored by dereckson on Jan 31 2017, 01:26.
Tags
None
Referenced Files
F2747270: D896.id.diff
Fri, Mar 29, 04:40
Unknown Object (File)
Thu, Mar 28, 01:45
Unknown Object (File)
Wed, Mar 27, 06:52
Unknown Object (File)
Sun, Mar 24, 08:01
Unknown Object (File)
Fri, Mar 22, 23:54
Unknown Object (File)
Fri, Mar 22, 06:34
Unknown Object (File)
Sun, Mar 17, 23:36
Unknown Object (File)
Sun, Mar 17, 19:35
Subscribers
None

Details

Summary

Composer installed 0.1.3, as the package version constraint was ~0.1.0.

This version can't correctly handle a property documented as mixed:

Notification
/**
 * The notification's source payload, data or message
 *
 * @var mixed
 */
public $rawContent;

With this version, JsonMapper raises the following issue:

Class '\Nasqueron\Notifications\Notifications\mixed' not found

This is a known bug, fixed upstream:
https://github.com/cweiske/jsonmapper/issues/33

The version is bumped to get this fix.

Test Plan

Run tests to ensure current mappings still work.

Test this code works:

private function getNotification () : Notification {
    $mapper = new \JsonMapper();
    return $mapper->map(
        json_decode($this->rawRequestContent),
        new Notification
    );
}

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
This revision is now accepted and ready to land.Jan 31 2017, 01:34
This revision was automatically updated to reflect the committed changes.