Page MenuHomeDevCentral

Bump jsonmapper to v1.1.1
ClosedPublic

Authored by dereckson on Jan 31 2017, 01:26.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 15, 00:59
Unknown Object (File)
Sat, Feb 14, 06:49
Unknown Object (File)
Fri, Feb 13, 02:25
Unknown Object (File)
Thu, Feb 5, 16:11
Unknown Object (File)
Thu, Feb 5, 13:36
Unknown Object (File)
Thu, Feb 5, 03:05
Unknown Object (File)
Wed, Feb 4, 23:39
Unknown Object (File)
Wed, Feb 4, 21:56
Subscribers
None

Details

Summary

Composer installed 0.1.3, as the package version constraint was ~0.1.0.

This version can't correctly handle a property documented as mixed:

Notification
/**
 * The notification's source payload, data or message
 *
 * @var mixed
 */
public $rawContent;

With this version, JsonMapper raises the following issue:

Class '\Nasqueron\Notifications\Notifications\mixed' not found

This is a known bug, fixed upstream:
https://github.com/cweiske/jsonmapper/issues/33

The version is bumped to get this fix.

Test Plan

Run tests to ensure current mappings still work.

Test this code works:

private function getNotification () : Notification {
    $mapper = new \JsonMapper();
    return $mapper->map(
        json_decode($this->rawRequestContent),
        new Notification
    );
}

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
bump-jsonmapper (branched from master)
Build Status
Buildable 1381
Build 1629: arc lint + arc unit

Event Timeline

dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
This revision is now accepted and ready to land.Jan 31 2017, 01:34
This revision was automatically updated to reflect the committed changes.