Differential D95

Degrade silently bit.ly API call on request failure
ClosedPublic
Actions

Authored by dereckson on Nov 30 2015, 04:45.

Details

Reviewers

dereckson

Maniphest Tasks

T601: Intercept BadResponseException in /lists/replace URI shorten feature

Commits

rTOOLS9ec4ad403649: Degrade silently bit.ly API call on request failure

Summary

If a too long URL is generated by the list replace tool, bit.ly API
throws a 500 error. To prevent this, we degrade silently to a regular
non-short URL mode when this occurs.

Fixes T601.

Test Plan

test with URL provided in bug case

Diff Detail

Repository

rTOOLS Nasqueron Tools

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

T601

Build Status

Buildable 104
Build 104: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 219.Nov 30 2015, 04:45

dereckson added a task: T601: Intercept BadResponseException in /lists/replace URI shorten feature.

dereckson retitled this revision from to Degrade silently bit.ly API call on request failure.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson planned changes to this revision.Nov 30 2015, 04:46

dereckson added inline comments.

lists/replace.php
121	It's not a time out error, but a 500.

More precise comment

Cleaned ommits selection

dereckson accepted this revision.Nov 30 2015, 04:50

dereckson edited edge metadata.

This revision is now accepted and ready to land.Nov 30 2015, 04:50

Closed by commit rTOOLS9ec4ad403649: Degrade silently bit.ly API call on request failure (authored by dereckson, committed by dereckson). · Explain WhyNov 30 2015, 04:51

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

4 lines

11 lines

31 lines

color/

screen/

_documents.xml

2 lines

composer.json

26 lines

css/

media-queries-generator.php

2 lines

dl.php

26 lines

finger/

6 lines

8 lines

1 line

180 lines

thimbl_inputForm.html

11 lines

gadgets/

generators/

32 lines

17 lines

284 lines

2 lines

list-generators.query.php

10 lines

wordsmanship-electronics.json

55 lines

wordsmanship.json

59 lines

motd-variations.php

1 line

generators/

GNOME/

10 lines

54 lines

149 lines

4 lines

4 lines

geocaching/

_documents.xml

7 lines

index.php

4 lines

string2number.html

160 lines

images/

Nasqueron.png

includes/

autoload.php

52 lines

cache/

cache.php

2 lines

memcached.php

1 line

void.php

1 line

controllers/

FilesListingController.php

62 lines

721 lines

17 lines

112 lines

3 lines

1 line

mysqli.php

149 lines

infographics/

datasources/

datasource.php

2 lines

mediawikidatasources.php

4 lines

pol.fr.assembleenationale.php

2 lines

pol.fr.senat.php

2 lines

parlement-fr.php

1 line

json/

46 lines

7 lines

114 lines

4 lines

lists/

18 lines

1 line

2 lines

25 lines

microblogging/

twitterpoints.php

6 lines

network/

_documents.xml

2 lines

mx.php

37 lines

package.json

31 lines

rnd/

_documents.xml

2 lines

stylesheets/

app.css

10 lines

react-select.css

233 lines

themes/

RalfFallsIntoFoundation/

footer.php

40 lines

header.php

1 line

transport/

TEC/

Map/

_documents.xml

4 lines

_documents.xml

2 lines

_documents.xml

2 lines

Commit	Tree	Parents	Author	Summary	Date
9ec4ad403649	01ad9013a157	98f1ba32874d	Sébastien Santoro	Degrade silently bit.ly API call on request failure (Show More…)	Nov 30 2015, 04:37
98f1ba32874d	317978dc9bfd	a4bd53cfa35b	Sébastien Santoro	Arcanist configuration (Show More…)	Nov 30 2015, 04:41
a4bd53cfa35b	80c1b380f87a	f7189fd2d9a2	Sébastien Santoro	Clean bit.ly related no-op code (Show More…)	Nov 30 2015, 04:34
f7189fd2d9a2	6a3238b1de47	90e5ab289f98	Sébastien Santoro	Whitespace issues (Show More…)	Nov 30 2015, 04:21
90e5ab289f98	952d88b291df	8a2fded4bbd3	Sébastien Santoro	Fixed whitespace issues	Sep 19 2015, 15:04
8a2fded4bbd3	abbcb14b231a	af2c6f1e3fbe	Sébastien Santoro	Fixed whitespace issue	Jul 29 2015, 22:17
af2c6f1e3fbe	cb1920ad7902	4990621298bb	Sébastien Santoro	[lists/replace] Shorten permanent URL through bit.ly	Jul 29 2015, 22:17
4990621298bb	be69c7163bfa	1711b5e7279e	Sébastien Santoro	API client to call bit.ly URL shorten service (Show More…)	Jul 29 2015, 22:15
1711b5e7279e	53b3557093d3	a5eb8363b9b9	Sébastien Santoro	Stack Tools and Composer autoloaders	Jul 29 2015, 22:04
a5eb8363b9b9	27cfeb7dae0d	cc0956bd6adc	Sébastien Santoro	[lists/replace] Gets a permanent URL for a query	Jun 24 2015, 16:59
cc0956bd6adc	b9c763cd5bdc	9a77db791dbf	Sébastien Santoro	[gadgets/generators] Removed duplicate entry from PàS datasource	Jun 22 2015, 21:37
9a77db791dbf	724dfb63f49b	6796a948b162	Sébastien Santoro	Fixed "Cannot read property 'craft'" issue. (Show More…)	Jun 16 2015, 20:20
6796a948b162	d8411b11d0a3	b168afa182f6	Sébastien Santoro	`make cleanjs compilejs` to regenerate the JS code (Show More…)	Jun 16 2015, 20:10
b168afa182f6	9fa0de95b328	863cc73af980 7cdfd8564aa2	Sébastien Santoro	Merge branch 'fix/live' of /var/wwwroot/nasqueron.org/tools	Jun 16 2015, 20:07
7cdfd8564aa2	ac25db5bcdc2	87e48a912ea0	Sébastien Santoro aka Dereckson	Removed closing PHP tags	Dec 4 2014, 19:52
87e48a912ea0	8886bddedd03	de7152d7c81e	Sébastien Santoro aka Dereckson	Disable infographics/parlement-fr (performance issue)	Sep 15 2014, 19:51
863cc73af980	a0c347e169bd	3ddb62846e3b	Sébastien Santoro	Added react-textarea-autosize component (Show More…)	Jun 16 2015, 19:13
3ddb62846e3b	17c6900c5052	f2c11ba95a54	Sébastien Santoro	package.json to ease npm use	Jun 16 2015, 19:12
f2c11ba95a54	07a70b52c17c	a8e30e0989eb	Sébastien Santoro	Sentences generator: fr.wikipedia PàS (Show More…)	Jun 16 2015, 17:40
a8e30e0989eb	cef5012a7122	3049d1b99c3c	Sébastien Santoro	New gadget: sentences generator	Jun 16 2015, 17:40
3049d1b99c3c	150cebd957a7	acc2b5b4ae30	Sébastien Santoro	CSS for react-select component (Show More…)	Jun 16 2015, 17:39
acc2b5b4ae30	b34e8f75f27b	a5626ceed817	Sébastien Santoro	Makefile and .gitignore for JS/React resources	Jun 16 2015, 17:38
a5626ceed817	554134c18620	9f55113e15ac	Sébastien Santoro	Datasource for sentences generator (Show More…)	Jun 16 2015, 16:13
9f55113e15ac	b266bc97cdaf	7c863a4f60c5	Sébastien Santoro	Load jQuery and Foundation JS in head (Show More…)	Jun 16 2015, 12:32
7c863a4f60c5	0512bbdd7180	c1c01c50d518	Sébastien Santoro	Fixed application name in app.css	Jun 5 2015, 11:40
c1c01c50d518	8c675762a300	26049aa43f67	Sébastien Santoro	Fixed typo in footer	Jun 16 2015, 00:18
26049aa43f67	2dff4a312975	6cdf965efcd0	Sébastien Santoro	/gadgets/generators/list-generators.query xhr entry point (Show More…)	Jun 16 2015, 00:15
6cdf965efcd0	0eae53ace99e	de7e12b3201a	Sébastien Santoro	Serve JSON .query files (Show More…)	Jun 15 2015, 23:18
de7e12b3201a	36f6b94f2d4d	f75c40a0c7d3	Sébastien Santoro	Fixed whitespace issues	Jun 15 2015, 23:10
f75c40a0c7d3	291436a77f63	adc296b237e6	Sébastien Santoro	FilesListingController: new controller to list current files (Show More…)	Jun 15 2015, 22:56
adc296b237e6	859ef397f334	aaee503f2532	Sébastien Santoro	[core] get_directory(): gets directory relative to the site root (Show More…)	Jun 15 2015, 22:52
aaee503f2532	c5b6e333e572	f58e96984269	Sébastien Santoro	[core] get_files(): get files in a directory	Jun 15 2015, 22:49
f58e96984269	99421215ce84	0b94a18d5798	Sébastien Santoro	Improved core code documentation	Jun 15 2015, 22:49
0b94a18d5798	3de646b42c48	e9184b6f27ba	Sébastien Santoro	Simplifying get_extension global function	Jun 15 2015, 22:46
e9184b6f27ba	31b3b703f8af	01bab4e27e5c	Sébastien Santoro	Autoloader for classes	Jun 15 2015, 22:45
01bab4e27e5c	1c5d9d8fe082	77370e2cf5ef	Sébastien Santoro	Don't hardcode server URL in Twitter intent call	Jun 7 2015, 09:47
77370e2cf5ef	c5ab1162b1bb	98a55c8057fd	Sébastien Santoro	Fixed whitespace issues	Jun 7 2015, 09:44
98a55c8057fd	1ff66cb0fc59	70de1b6199ad	Sébastien Santoro	[geocaching/string2number] Moved source comment to directly relevant part	Mar 8 2015, 19:15
70de1b6199ad	e08b7fb453c5	723105c9a579	Sébastien Santoro	[geocaching/string2number] Handle accentuated characters (Show More…)	Mar 8 2015, 19:10
723105c9a579	a6387d16cb7a	dd1d43559509	Sébastien Santoro	[geocaching/string2number] Improved description (Show More…)	Mar 8 2015, 15:39
dd1d43559509	86ddf2666a2e	d9816f35a4c6	Sébastien Santoro	New tool: string to number (Geocaching) (Show More…)	Mar 8 2015, 13:37
d9816f35a4c6	6fdec8d488f9	98e5578698c2	Sébastien Santoro	Removed trailing ?>	Dec 4 2014, 08:44
98e5578698c2	99066e014a97	de7152d7c81e	Sébastien Santoro	Removing trailing / in .gitignore tool folder	Dec 4 2014, 08:40
de7152d7c81e	7b7b6ef9144f	c46466f6c476	Dereckson	Fixing whitespace issues	Nov 23 2014, 11:34
c46466f6c476	d620679ab2d0	1b070820c3d4	Dereckson	Code documentation: Array → array (Show More…)	Nov 23 2014, 11:31
1b070820c3d4	c56c401b8c96	9db7d7097b93	Dereckson	Dependencies are now managed by Composer (Show More…)	Nov 23 2014, 05:36
9db7d7097b93	658eccabc6e2	bd10b3845fc6	Dereckson	Removed wikimedia/write/sourcetemplatesgenerator submodule (Show More…)	Nov 23 2014, 04:24
bd10b3845fc6	b57388f07882	096ba4469d28	Dereckson	Refactored /finger/thimbl to handle issues more easily (Show More…)	Nov 23 2014, 03:39
096ba4469d28	1706b0efc899	ff80f0f27323	Dereckson	Improving network/mx tool (Show More…)	Aug 27 2014, 20:57
ff80f0f27323	5b55849add94	388575b3bdc2	Dereckson	Adding Freedesktop/GNOME .desktop file generator	Aug 27 2014, 20:48
388575b3bdc2	3762b06bd247	859e06e6f017	Dereckson	Adding MySQLi support, enabled it by default	Aug 27 2014, 20:36
859e06e6f017	9f62f7edff81	68ac5b5c45c2	Dereckson	Removing control character (0xFEFF)	Jul 9 2014, 17:55
68ac5b5c45c2	f4dafad6123e	9e2d964dacad	Dereckson	Code style: removing extra blank line	Feb 16 2014, 22:47
9e2d964dacad	9446b4ecb76c	36249971cfc9	Dereckson	/json/excel2json: allows tab in textareas	Feb 16 2014, 22:08
36249971cfc9	bb8c09a606c4	e628b8e665c7	Dereckson	New tool: Excel to JSON converter (Show More…)	Feb 16 2014, 21:38
e628b8e665c7	edce0f36faf6	4892644e007b	Dereckson	Entry point to send a file to download by the client	Feb 16 2014, 21:36
4892644e007b	ae90d20b4809	c9898d16dc99	Dereckson	Updating wikimedia/write/sourcetemplatesgenerator (Show More…)	Jan 19 2014, 14:59
c9898d16dc99	2d5493686679	c6c79bbc34b2	Dereckson	Fixing incomplete submodule for wikimedia/write/sourcetemplatesgenerator	Jan 19 2014, 14:55
c6c79bbc34b2	d58ab9685ffd	5fb0d8590aa5	Dereckson	Fixing topics in _documents.xml files	Jan 12 2014, 17:16
5fb0d8590aa5	486ca02cec3e	7b6d05016be5	Dereckson	Fixing typo in Media queries generator page.	Jan 12 2014, 16:32
7b6d05016be5	107087f7bf23	5bc94446a80b	Dereckson	Nasqueron footer branding	Jan 12 2014, 16:31