Differential D994

Configure systemd unit to restart Odderon on non 0 exit
ClosedPublic
Actions

Authored by dereckson on Jun 3 2017, 19:05.

Tags

Referenced Files

	F3752553: D994.id2539.diff
	Sun, Nov 17, 19:37

	Unknown Object (File)
	Fri, Nov 15, 18:14

	Unknown Object (File)
	Tue, Nov 12, 18:04

	Unknown Object (File)
	Sat, Nov 9, 21:53

	Unknown Object (File)
	Mon, Nov 4, 14:38

	Unknown Object (File)
	Mon, Nov 4, 14:37

	Unknown Object (File)
	Mon, Nov 4, 14:18

	Unknown Object (File)
	Thu, Oct 31, 01:24

Subscribers

None

Details

Reviewers

Sandlayth
dereckson

Maniphest Tasks

T1213: Odderon doesn't restart after a non 0 exit code

Commits

rOPS2ecd36350302: Configure systemd unit to restart Odderon on non 0 exit

Summary

The darkbot software implements a feature to catch exceptions like
a segmentation fault, and then exits properly the software with
a non zero code.

The quit message on IRC explains the intercepted signal:
Quit: Caught SIG_SEGV! Aborting connection. Uptime: 893 hours, 10 mins

In such case, we want systemd to immediately restart the service,
to improve service availability. This is not the default behavior,
as systemd prefers to mark unit status as failed.

Reference: https://www.freedesktop.org/software/systemd/man/systemd.service.html#Restart=

Fixes T1213.

Test Plan

Deploy on Eglide
- Function service.force_reload from odderon_unit took care to reload systemd configuration
- Function service.running from odderon_running state took care to restart the service
Unit status switched from failed to an active (running).

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

restart-odderon-on-unclean-exit (branched from master)

Build Status

Buildable 1549
Build 1797: arc lint + arc unit

Event Timeline

dereckson created this revision.Jun 3 2017, 19:05

dereckson edited the test plan for this revision. (Show Details)Jun 3 2017, 19:11

dereckson added a project: systemd.

dereckson edited the summary of this revision. (Show Details)Jun 5 2017, 12:24

dereckson edited the summary of this revision. (Show Details)

Sandlayth accepted this revision.Jun 5 2017, 21:18

This revision is now accepted and ready to land.Jun 5 2017, 21:18

dereckson accepted this revision.Jun 12 2017, 21:23

Closed by commit rOPS2ecd36350302: Configure systemd unit to restart Odderon on non 0 exit (authored by dereckson, committed by dereckson). · Explain WhyJun 12 2017, 21:24

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

shellserver/

odderon/

files/

odderon.service

1 line

Diff 2538

roles/shellserver/odderon/files/odderon.service

Loading...