Page MenuHomeDevCentral
Files F3776802

D871.id2287.diff
No OneTemporary
Actions

D871.id2287.diff
View Options

diff --git a/app/Http/Controllers/Gate/GateController.php b/app/Http/Controllers/Gate/GateController.php
--- a/app/Http/Controllers/Gate/GateController.php
+++ b/app/Http/Controllers/Gate/GateController.php
@@ -117,4 +117,12 @@
return "";
}
+ ///
+ /// Helper methods
+ ///
+
+ protected function getServiceName () : string {
+ return static::SERVICE_NAME;
+ }
+
}
diff --git a/app/Http/Controllers/Gate/NotificationGateController.php b/app/Http/Controllers/Gate/NotificationGateController.php
new file mode 100644
--- /dev/null
+++ b/app/Http/Controllers/Gate/NotificationGateController.php
@@ -0,0 +1,139 @@
+<?php
+
+namespace Nasqueron\Notifications\Http\Controllers\Gate;
+
+use Nasqueron\Notifications\Events\NotificationEvent;
+use Nasqueron\Notifications\Notifications\Notification;
+
+use Symfony\Component\HttpFoundation\Response;
+
+use Event;
+use Request;
+
+use InvalidArgumentException;
+
+class NotificationGateController extends GateController {
+
+ ///
+ /// Private members
+ ///
+
+ /**
+ * The request content, as a structured data
+ *
+ * @var \stdClass
+ */
+ private $payload;
+
+ /**
+ * The request content
+ *
+ * @var string
+ */
+ private $rawRequestContent;
+
+ ///
+ /// Request processing
+ ///
+
+ /**
+ * Handles POST requests
+ *
+ * @param string $door The door, matching the project for this payload
+ * @return \Symfony\Component\HttpFoundation\Response
+ */
+ public function onPost (string $door) : Response {
+ // Parses the request and check if it's legit
+
+ $this->door = $door;
+
+ try {
+ $this->extractPayload();
+ $this->normalizePayload();
+ } catch (InvalidArgumentException $ex) {
+ abort(400, 'Bad request.');
+ }
+
+ // Process the request
+
+ $this->logRequest();
+ $this->onPayload();
+
+ // Output
+
+ return parent::renderReport();
+ }
+
+ /**
+ * Extracts payload from the request
+ */
+ protected function extractPayload () {
+ $request = Request::instance();
+ $this->rawRequestContent = $request->getContent();
+ $this->payload = $this->getNotification();
+ }
+
+ protected function getServiceName () : string {
+ return (string)$this->payload->service;
+ }
+
+ ///
+ /// Helper methods to get notification
+ ///
+
+ private function getNotification () : Notification {
+ $payload = json_decode($this->rawRequestContent);
+ if ($payload === null) {
+ throw new InvalidArgumentException("Invalid JSON");
+ }
+
+ $mapper = new \JsonMapper();
+ return $mapper->map(
+ $payload,
+ new Notification
+ );
+ }
+
+ private function normalizePayload () : void {
+ $this->normalizeProject();
+ $this->ensureRequiredPayloadFieldsArePresent();
+ }
+
+ private function normalizeProject () : void {
+ if (!$this->isPayloadFieldPresent('project')) {
+ $this->payload->project = $this->door;
+ }
+ }
+
+ private function ensureRequiredPayloadFieldsArePresent () : void {
+ foreach ($this->getMandatoryPayloadFields() as $field) {
+ if (!$this->isPayloadFieldPresent($field)) {
+ throw new InvalidArgumentException("Field $field is missing.");
+ }
+ }
+ }
+
+ private function getMandatoryPayloadFields () : array {
+ return [
+ 'service',
+ 'project',
+ 'group',
+ 'type',
+ ];
+ }
+
+ private function isPayloadFieldPresent (string $field) : bool {
+ return (string)$this->payload->$field !== "";
+ }
+
+ ///
+ /// Payload processing
+ ///
+
+ protected function onPayload () {
+ $this->initializeReport();
+
+ Event::fire(new NotificationEvent($this->payload));
+ }
+
+}
diff --git a/config/gate.php b/config/gate.php
--- a/config/gate.php
+++ b/config/gate.php
@@ -13,6 +13,10 @@
*/
'controllers' => [
+ // Native notifications
+ 'Notification',
+
+ // External services
'DockerHub',
'GitHub',
'Jenkins',
diff --git a/tests/data/config.json b/tests/data/config.json
--- a/tests/data/config.json
+++ b/tests/data/config.json
@@ -1,5 +1,6 @@
{
"gates": [
+ "Notification",
"DockerHub",
"GitHub",
"Jenkins",

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 25, 23:20 (20 h, 40 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2263467
Default Alt Text
D871.id2287.diff (4 KB)

Event Timeline

Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator