P279 highlights some ways to improve shell scripts in the following files:

• roles/mailserver/certificates/files/update-smtp-certificates.sh
• roles/mailserver/dkim/files/bin/get-dkim-dns-entries.sh
• roles/mailserver/dkim/files/bin/get-dkim-key-table.sh
• roles/mailserver/dkim/files/bin/get-dkim-signing-table.sh
• roles/mailserver/systemd-unit/files/lxc-container-mailserver-start.sh
• roles/mailserver/systemd-unit/files/lxc-container-mailserver-stop.sh
• roles/mumble/certificates/files/update-mumble-certificates.sh
• roles/phabricator/arcanist/files/arc.sh
• roles/phabricator/containers/files/run-devcentral.sh
• roles/phabricator/containers/files/run-wolfphab.sh
• roles/shellserver/user-session/files/whom-diff.sh
• roles/webserver-core/letsencrypt/files/letsencrypt-renewal.sh

Do you wish to solve this?

This task has been identified as suitable for newcomers on our code base.

• Clone the rOPS repository
• Install Arcanist: arc paste P279 will print a colored output of the issues
• Or you can also run shellcheck <filename>
• Send one commit per file fixed to ease review