Page MenuHomeDevCentral
Create Task
Maniphest T2145

Consolidate Obsidian classes with Keruald resources
Open, NormalPublic
Actions

Description

Obsidian follows Azhàr / Keruald includes structure.

As such, some of the code can be duplicated from code already migrated to rKERUALD. Other missing methods could be migrated there, as Obsidian is a little more modern.

Revisions and Commits

rOBSIDIAN Obsidian Workspaces
D3774rOBSIDIANdd8b7e76c36c Switch events and databases class to Keruald packages implementations

Related Objects

Event Timeline

dereckson triaged this task as Normal priority.Fri, Oct 17, 16:50
dereckson created this task.
dereckson mentioned this in T157: Switch database from UTF-8 to utf8mb4 both on MySQL standard connection and MySQL document provider.
dereckson added a comment.Sun, Oct 19, 08:02

Looking the code of keruald/databases, it's clear that it's exactly based on Obsidian consolidated design choices: Keruald Databases even use the camelCase method names introduced in Obsidian, with a WithLegacyMethods trait to stay compatible with other applications.

The only changes are:

  • code to fire the event wasn't ported, we wanted a package keruald/events for that
  • Database engine selection is done by 'engine' => 'MySQL' in Obsidian, 'engine' => MySQLiEngine::class in Keruald code
dereckson moved this task from Next to Working on on the Obsidian board.Sun, Oct 19, 10:05
dereckson mentioned this in D3772: Propagate database events.Sun, Oct 19, 10:06
dereckson mentioned this in rKERUALD85207350c60e: Propagate database events.Sun, Oct 19, 12:09
dereckson mentioned this in rKOT17d6ef4f4010: Propagate database events.Sun, Oct 19, 12:14
dereckson mentioned this in rKDBad417e25084d: Propagate database events.
dereckson added a commit: rOBSIDIANdd8b7e76c36c: Switch events and databases class to Keruald packages implementations.Sun, Oct 19, 21:45
dereckson added a revision: D3774: Switch events and databases classes to Keruald packages implementations.
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator