Differential D3862

Refactor Workspace::get_user_workspaces
ClosedPublic
Actions

Authored by dereckson on Nov 10 2025, 02:34.

Tags

None

Referenced Files

	F19220239: D3862.id10001.diff
	Thu, Dec 25, 13:59

	Unknown Object (File)
	Thu, Dec 25, 10:05

	Unknown Object (File)
	Wed, Dec 24, 21:11

	Unknown Object (File)
	Wed, Dec 24, 15:16

	Unknown Object (File)
	Wed, Dec 24, 01:04

	Unknown Object (File)
	Tue, Dec 23, 22:34

	Unknown Object (File)
	Tue, Dec 23, 17:38

	Unknown Object (File)
	Tue, Dec 23, 08:21

View All 65 Files

Subscribers

None

Details

Reviewers

Commits

rOBSIDIANe015a94a4aae: Refactor Workspace::get_user_workspaces

Summary

With a void cache, the null value returned by the cache was passed to unserialize code.

While this issue was left aside to replace current caches classes by keruald/cache,
the function can already be split between cache/database query/build object methods.

This fixes the following issue:
[09-Nov-2025 16:47:46 UTC] PHP Deprecated:
unserialize(): Passing null to parameter #1 ($data) of type string is deprecated
in /var/51-wwwroot/obsidian/workspaces/src/Engines/Workspaces/Workspace.php on line 229

Test Plan

Check if the list in navbar header still contains workspaces.

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Nov 10 2025, 02:34

dereckson created this revision.

Harbormaster completed remote builds in B6165: Diff 10001.Nov 10 2025, 02:34

dereckson accepted this revision.Nov 10 2025, 02:36

This revision is now accepted and ready to land.Nov 10 2025, 02:36

Closed by commit rOBSIDIANe015a94a4aae: Refactor Workspace::get_user_workspaces (authored by dereckson). · Explain WhyNov 10 2025, 02:36

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIANe015a94a4aae: Refactor Workspace::get_user_workspaces.

Revision Contents
Changeset List

Path

Size

workspaces/

src/

Engines/

Workspaces/

69 lines

Diff 10002

workspaces/src/Engines/Workspaces/Workspace.php

Loading...