Page MenuHomeDevCentral
Differential D3990

Standardize NTP configuration
Needs ReviewPublic
Actions

Authored by ptdradmin on Tue, Mar 3, 14:04.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 14, 10:27
Unknown Object (File)
Sat, Mar 14, 08:09
Unknown Object (File)
Sat, Mar 14, 07:05
Unknown Object (File)
Sat, Mar 14, 00:13
Unknown Object (File)
Fri, Mar 13, 22:59
Unknown Object (File)
Fri, Mar 13, 03:10
Unknown Object (File)
Thu, Mar 12, 17:26
Unknown Object (File)
Thu, Mar 12, 10:27
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1223: Configure NTP in rOPS
Summary
  • Centralize NTP servers in Pillar
  • Update templates for Chrony and NTpd
  • Manage ntpdate and ntp.conf on FreeBSD

Ref T1223

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
feature/ntp-standardization-T1223
Build Status
Buildable 6472
Build 6756: arc lint + arc unit

Event Timeline

ptdradmin requested review of this revision.Tue, Mar 3, 14:04
ptdradmin created this revision.
Harbormaster completed remote builds in B6396: Diff 10348.Tue, Mar 3, 14:04
ptdradmin updated this revision to Diff 10349.Tue, Mar 3, 14:08

Remove accidental file t

Harbormaster completed remote builds in B6397: Diff 10349.Tue, Mar 3, 14:08
ptdradmin updated this revision to Diff 10351.Tue, Mar 3, 14:27

Standardize NTP configuration (T1223) - v2

Harbormaster completed remote builds in B6399: Diff 10351.Tue, Mar 3, 14:27
dereckson retitled this revision from Standardize NTP configuration (T1223) to Standardize NTP configuration.Tue, Mar 3, 17:58
dereckson edited the summary of this revision. (Show Details)
dereckson added a task: T1223: Configure NTP in rOPS.
dereckson added a comment.Wed, Mar 4, 06:34

Pillar OK.

Configuration templates OK, with proper headers.

Open questions for the role logic:

  • ntpd vs ntpdate -> which one to run on FreeBSD? We'll need to drop the other one
  • servers are defined twice, one in RC config, one in NTP configuration, which one we keep?

From T2192 and https://agora.nasqueron.org/Operations_grimoire/NTP#FreeBSD:

  • ntpd is favoured
dereckson requested changes to this revision.Wed, Mar 4, 06:38
dereckson added inline comments.
roles/core/ntp/init.sls
53

We don't need that one, but we'd need a /etc/rc.conf.d/ntpd file with as content:

ntpd_enable="YES"

This revision now requires changes to proceed.Wed, Mar 4, 06:38
ptdradmin updated this revision to Diff 10376.Wed, Mar 4, 15:57

Apply feedback: use YES (quotes) and add ntpd_sync_on_start

Harbormaster completed remote builds in B6421: Diff 10376.Wed, Mar 4, 15:57
ptdradmin updated this revision to Diff 10377.Wed, Mar 4, 16:01

Fix FreeBSD configuration based on dereckson feedback

Harbormaster completed remote builds in B6422: Diff 10377.Wed, Mar 4, 16:01
ptdradmin updated this revision to Diff 10378.Wed, Mar 4, 16:02

Final fix: remove ntpdate state from init.sls

Harbormaster completed remote builds in B6423: Diff 10378.Wed, Mar 4, 16:02
ptdradmin updated this revision to Diff 10379.EditedWed, Mar 4, 16:07

Final cleanup: dereckson feedback and fix file corruption

Harbormaster completed remote builds in B6424: Diff 10379.Wed, Mar 4, 16:07
dereckson added inline comments.Wed, Mar 11, 17:56
roles/core/ntp/init.sls
18

Actually we're normalizing with " right now.

ptdradmin updated this revision to Diff 10439.Sun, Mar 15, 13:20

Normalize to double quotes in Jinja templates as requested

Harbormaster completed remote builds in B6472: Diff 10439.Sun, Mar 15, 13:20

Revision Contents
Changeset List

PathSize
pillar/
core/
12 lines
1 line
roles/
core/
ntp/
files/
chrony.conf.jinja/
rc/
ntpd.conf
14 lines
ntp.conf.jinja/
rc/
ntpd.conf
17 lines
rc/
2 lines
27 lines

Diff 10439

View Options

pillar/core/ntp.sls

Loading...
View Options

pillar/top.sls

Loading...
View Options

roles/core/ntp/files/chrony.conf.jinja

Loading...
View Options

roles/core/ntp/files/ntp.conf.jinja

Loading...
View Options

roles/core/ntp/files/rc/ntpd.conf

Loading...
View Options

roles/core/ntp/init.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator