Page MenuHomeDevCentral
Differential D4036

Configure a dedicated syslog file for carp-ovh logs
ClosedPublic
Actions

Authored by yousra on Thu, Apr 2, 12:50.
Tags
None
Referenced Files
F26475679: D4036.id10670.diff
Thu, Apr 23, 03:59
F26475676: D4036.id10692.diff
Thu, Apr 23, 03:59
F26417403: D4036.id10670.diff
Wed, Apr 22, 17:44
Unknown Object (File)
Wed, Apr 22, 07:24
Unknown Object (File)
Wed, Apr 22, 07:24
Unknown Object (File)
Tue, Apr 21, 18:11
Unknown Object (File)
Tue, Apr 21, 18:11
Unknown Object (File)
Tue, Apr 21, 18:11
View All 65 Files
Subscribers
dereckson
Duranzed

Details

Reviewers
dereckson
Duranzed
Maniphest Tasks
T2292: Create syslog configuration for CARP
Commits
rOPSf835d7a6037c: Configure a dedicated syslog file for carp-ovh logs
Summary

This change adds:

  • a dedicated log file at /var/log/carp.log
  • a syslog configuration file in /usr/local/etc/syslog.d/carp.conf to redirect carp-ovh logs to /var/log/carp.log
  • a newsyslog configuration file in /etc/newsyslog.conf.d/carp.conf to rotate and compress carp log files

Ref T2292

Test Plan
  • salt 'router-003' state.apply roles/router
  • salt 'router-002' state.apply roles/router
  • Restart syslogd
  • Simulate failover
  • Verify the logs for carp-ovh is written to /var/log/carp.log with tail -f /var/log/carp.log

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Skipped
Unit
No Test Coverage
Branch
log-file-carp
Build Status
Buildable 6558
Build 6842: arc lint + arc unit

Event Timeline

yousra requested review of this revision.Thu, Apr 2, 12:50
yousra created this revision.
Harbormaster completed remote builds in B6554: Diff 10546.Thu, Apr 2, 12:50
yousra edited the summary of this revision. (Show Details)Thu, Apr 2, 12:51
yousra added a task: T2292: Create syslog configuration for CARP.
yousra updated this revision to Diff 10547.Thu, Apr 2, 14:11

carp-ovh logs were written both to /var/log/messages and /var/log/carp.log.
This change redirects them only to /var/log/carp.log by excluding them from /var/log/messages.

The "~" discard rule was not suitable because /etc/syslog.conf is processed before /usr/local/etc/syslog.d/carp.conf.
So logs are already written to /var/log/messages at that stage.

Harbormaster completed remote builds in B6555: Diff 10547.Thu, Apr 2, 14:11
yousra updated this revision to Diff 10550.Thu, Apr 2, 22:45
  • '0XXX" into XXX : correct permissions for Salt
Harbormaster completed remote builds in B6558: Diff 10550.Thu, Apr 2, 22:45
yousra updated this revision to Diff 10571.Tue, Apr 7, 12:35

I reordered the arguments, placing mode after makedirs

Harbormaster completed remote builds in B6578: Diff 10571.Tue, Apr 7, 12:35
dereckson added inline comments.Sat, Apr 18, 16:43
roles/router/carp/init.sls
44

Actually, newsyslog will create that file with the C flag you put in /var/log/carp.log root:wheel 644 7 1000 * JC, so we can remove this block.

yousra updated this revision to Diff 10670.Sat, Apr 18, 20:38

Removed /var/log/carp.log state because it is created automatically by newsyslog.

Harbormaster completed remote builds in B6643: Diff 10670.Sat, Apr 18, 20:38
dereckson accepted this revision.Sun, Apr 19, 16:59
This revision is now accepted and ready to land.Sun, Apr 19, 16:59
Closed by commit rOPSf835d7a6037c: Configure a dedicated syslog file for carp-ovh logs (authored by yousra). · Explain WhySun, Apr 19, 18:56
This revision was automatically updated to reflect the committed changes.
yousra added a commit: rOPSf835d7a6037c: Configure a dedicated syslog file for carp-ovh logs.

Revision Contents
Changeset List

PathSize
roles/
router/
carp/
files/
16 lines
18 lines
25 lines

Diff 10550

View Options

roles/router/carp/files/newsyslog.conf

Loading...
View Options

roles/router/carp/files/syslog.conf

Loading...
View Options

roles/router/carp/init.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator