Modified acme.sh pkg installation
Needs RevisionPublic
Actions

Authored by Duranzed on Thu, Apr 9, 18:38.

Details

Reviewers

DorianWinty
dereckson

Test Plan

install acme.sh on 2 types of servers

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

acmesh

Build Status

Buildable 6594
Build 6878: arc lint + arc unit

Event Timeline

Duranzed requested review of this revision.Thu, Apr 9, 18:38

Duranzed created this revision.

Harbormaster completed remote builds in B6591: Diff 10589.Thu, Apr 9, 18:38

modified acme.sh pkg installation

Harbormaster completed remote builds in B6592: Diff 10590.Thu, Apr 9, 18:52

dereckson requested changes to this revision.Thu, Apr 9, 19:19

dereckson added inline comments.

roles/core/certificates/acmesh.sls
17	Also exists for Debian - https://manpages.debian.org/unstable/acme.sh/acme.sh.1.en.html Please provide a package for RHEL if that's the one missing on packages.nasqueron.org.

This revision now requires changes to proceed.Thu, Apr 9, 19:19

dereckson mentioned this in T2304: Package acme.sh for RHEL.Thu, Apr 9, 19:21

Keeping package-based installation only

Harbormaster completed remote builds in B6593: Diff 10591.Mon, Apr 13, 12:27

Changed minor syntax

Harbormaster completed remote builds in B6594: Diff 10592.Mon, Apr 13, 12:29

This if condition is a currently an always true for our infrastructure as it says "if "OS/distro is every OS we currently have".

Per https://en.wikipedia.org/wiki/KISS_principle we can:

right now, keep the software procedure as is
when a distribution packages acme.sh under another name, use map.jinja

This revision now requires changes to proceed.Mon, Apr 13, 12:50

Revision Contents
Changeset List

Path

Size

roles/

core/

certificates/

acmesh.sls

4 lines

Diff 10592

View Options

roles/core/certificates/acmesh.sls

Modified acme.sh pkg installationNeeds RevisionPublicActions