Differential D4079

Test X-Hub-Signature-256 documentation values
Needs ReviewPublic
Actions

Authored by dereckson on Sat, Apr 18, 13:25.

Details

Reviewers

DorianWinty

Maniphest Tasks

T2310: Support X-Hub-Signature-256

Summary

This change demonstrates in tests the XHubSignature code
is actually ready for X-Hub-Signature-256.

Ref T2310

Test Plan

New unit test provided with a SHA-256 algo

The values of that test are taken from GitHub documentation:
https://docs.github.com/en/webhooks/using-webhooks/validating-webhook-deliveries

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Errors

Severity	Location	Code	Message
Error	github/tests/XHubSignatureTest.php:9	PHPCS.E.PSR1.Classes.ClassDeclaration.MissingNamespace	PSR1.Classes.ClassDeclaration.MissingNamespace

Unit

Test Failures

Branch

T2310-X-Hub-Signature-256

Build Status

Buildable 6632
Build 6916: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/home/dereckson/dev/keruald/_monorepo/core/github/tests/XHubSignatureTest.php

Event Timeline

dereckson requested review of this revision.Sat, Apr 18, 13:25

dereckson created this revision.

Harbormaster completed remote builds in B6632: Diff 10644.Sat, Apr 18, 13:25

Unit tests

$ phpunit github 
Switching to Composer phpunit:
PHPUnit 12.5-dev by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.30
Configuration: /home/dereckson/dev/keruald/_monorepo/core/phpunit.xml

......                                                              6 / 6 (100%)

Time: 00:00.012, Memory: 16.00 MB

OK (6 tests, 12 assertions)