Page MenuHomeDevCentral
Differential D4097

Rotate GRE tunnels log
ClosedPublic
Actions

Authored by Duranzed on Wed, Apr 29, 16:36.
Tags
None
Referenced Files
F28219133: D4097.diff
Sun, May 10, 16:55
F28200153: D4097.id10736.diff
Sun, May 10, 13:30
F28186596: D4097.id10726.diff
Sun, May 10, 11:40
Unknown Object (File)
Sat, May 9, 11:13
Unknown Object (File)
Sat, May 9, 05:08
Unknown Object (File)
Sat, May 9, 03:54
Unknown Object (File)
Sat, May 9, 02:28
Unknown Object (File)
Sat, May 9, 01:53
View All 41 Files
Subscribers
None

Details

Reviewers
dereckson
yousra
Maniphest Tasks
T2322: Create log file for GRE tunnel creation script
Commits
rOPSd1c7ad24bd42: Rotate GRE tunnels log
Summary

This log is used by GRE failover script.

Ref T2322

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Duranzed requested review of this revision.Wed, Apr 29, 16:36
Duranzed created this revision.
Harbormaster completed remote builds in B6677: Diff 10720.Wed, Apr 29, 16:36
dereckson requested changes to this revision.Wed, Apr 29, 17:46
dereckson added inline comments.
roles/core/network/gre_logging.sls
7

This idea of chmod in quotes is to allow the Ansible parser to parse as octal number, not as integer.

We use Salt, 644 is fine.

This revision now requires changes to proceed.Wed, Apr 29, 17:46
Duranzed updated this revision to Diff 10722.Wed, Apr 29, 18:34

syntax correction

Harbormaster completed remote builds in B6679: Diff 10722.Wed, Apr 29, 18:34
dereckson requested changes to this revision.Fri, May 1, 14:19
dereckson retitled this revision from log files for GRE creation tunnels to Rotate GRE tunnels log.
dereckson edited the summary of this revision. (Show Details)
dereckson added inline comments.
roles/core/network/gre_logging.sls
16

You put a C in newsyslog configuration file, so newsyslog will create that file, you can remove this block.

This revision now requires changes to proceed.Fri, May 1, 14:19
Duranzed updated this revision to Diff 10726.Fri, May 1, 15:05

Removed the redundant log file creation block, as newsyslog already creates the file via the C flag.

Harbormaster completed remote builds in B6683: Diff 10726.Fri, May 1, 15:05
Duranzed marked 2 inline comments as done.Fri, May 1, 15:06
dereckson accepted this revision.Fri, May 1, 17:59
This revision is now accepted and ready to land.Fri, May 1, 17:59
yousra edited the summary of this revision. (Show Details)Tue, May 5, 11:38
yousra added a task: T2322: Create log file for GRE tunnel creation script.
Closed by commit rOPSd1c7ad24bd42: Rotate GRE tunnels log (authored by Duranzed). · Explain WhyTue, May 5, 11:43
This revision was automatically updated to reflect the committed changes.
Duranzed added a commit: rOPSd1c7ad24bd42: Rotate GRE tunnels log.
yousra mentioned this in D4101: Update GRE tunnels syslog configuration.Thu, May 7, 23:40

Revision Contents
Changeset List

PathSize
roles/
core/
network/
files/
16 lines
17 lines
19 lines

Diff 10736

View Options

roles/core/network/files/newsyslog_gre.conf

Loading...
View Options

roles/core/network/files/syslog_gre.conf

Loading...
View Options

roles/core/network/gre_logging.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator