Page MenuHomeDevCentral
Differential D4112

Declare regular expression patterns as raw Python strings
ClosedPublic
Actions

Authored by dereckson on Sat, Jul 4, 12:09.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 25, 00:48
Unknown Object (File)
Fri, Jul 24, 18:22
Unknown Object (File)
Fri, Jul 24, 02:10
Unknown Object (File)
Thu, Jul 23, 13:46
Unknown Object (File)
Thu, Jul 16, 00:01
Unknown Object (File)
Wed, Jul 15, 16:01
Unknown Object (File)
Wed, Jul 15, 14:48
Unknown Object (File)
Wed, Jul 15, 11:59
View All 29 Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPSe929b23c05a0: Declare regular expression patterns as raw Python strings
Summary

This follow current Python style best practice when no escape
is needed, and avoid a syntax warning when the string escapes
a character only to be escaped for regexp, not for Python strings.

Fixes the following issue on Python 3.12+:

/usr/local/bin/shell:138: SyntaxWarning: invalid escape sequence '\|'
  matches = re.search("(.*)\|(.*)", variable)

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
main
Build Status
Buildable 6723
Build 7011: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Sat, Jul 4, 12:09
dereckson created this revision.
Harbormaster completed remote builds in B6723: Diff 10787.Sat, Jul 4, 12:09
dereckson accepted this revision.Sat, Jul 4, 12:14
dereckson edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sat, Jul 4, 12:14
Closed by commit rOPSe929b23c05a0: Declare regular expression patterns as raw Python strings (authored by dereckson). · Explain WhySat, Jul 4, 12:14
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOPSe929b23c05a0: Declare regular expression patterns as raw Python strings.

Revision Contents
Changeset List

PathSize
_modules/
2 lines
roles/
devserver/
userland-software/
files/
4 lines
salt-primary/
software/
files/
2 lines

Diff 10787

View Options

_modules/network_utils.py

Loading...
View Options

roles/devserver/userland-software/files/shell.py

Loading...
View Options

roles/salt-primary/software/files/staging-commit-message.py

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator