Page MenuHomeDevCentral

UserExternalSource: cast user_id property as integer
ClosedPublic

Authored by dereckson on Jul 2 2016, 08:59.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 1, 17:05
Unknown Object (File)
Sun, Jun 1, 00:15
Unknown Object (File)
Sat, May 31, 07:07
Unknown Object (File)
Fri, May 30, 16:33
Unknown Object (File)
Tue, May 20, 11:10
Unknown Object (File)
Mon, May 12, 10:46
Unknown Object (File)
Sat, May 10, 21:16
Unknown Object (File)
Sat, May 10, 14:50
Subscribers
None

Details

Summary

Code using the UserExternalSource model expects user ID to be
an integer, and not a string:

$externalUser = UserExternalSource::find(1);
// Does something with $externalUser->user_id

Eloquent allows to specify attributes casting with a $casts array.

Test Plan

Tested through D445 new unit test which provide:
$this->assertSame($externalUser->user_id, 1);

Diff Detail

Repository
rGROVE Auth Grove
Lint
Lint Passed
Unit
No Test Coverage
Branch
model
Build Status
Buildable 622
Build 741: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to UserExternalSource: cast user_id property as integer.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 2 2016, 08:59
This revision was automatically updated to reflect the committed changes.