Page MenuHomeDevCentral

Fix to source code
ClosedPublic

Authored by dereckson on Jul 23 2016, 18:46.
Tags
None
Referenced Files
F55407704: D540.diff
Thu, Oct 29, 04:45
Unknown Object (File)
Tue, Oct 13, 13:42
Unknown Object (File)
Tue, Oct 13, 13:41
Unknown Object (File)
Sun, Oct 11, 03:17
Unknown Object (File)
Sat, Oct 10, 16:33
Unknown Object (File)
Sat, Oct 10, 13:03
Unknown Object (File)
Sat, Oct 10, 10:27
Unknown Object (File)
Fri, Oct 9, 10:16
Subscribers
None

Details

Summary

A code review shows some minor interesting fixes to do .

  • use "" for charset in SCSS *
  • optimize background CSS declaration *
  • use {{root}} to mark website root in templates
  • add some blank lines

(*) Detected through WebStorm code inspection

Test Plan

Check code correctness in Firefox and Chrome

Diff Detail

Repository
rVIPERWWW Dæghrefn website
Lint
Lint Passed
Unit
No Test Coverage
Branch
improve-source-code
Build Status
Buildable 776
Build 910: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to Fix to source code.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jul 23 2016, 18:47
This revision was automatically updated to reflect the committed changes.