Differential D614

Explicitely set visibility to public methods
ClosedPublic
Actions

Authored by dereckson on Aug 17 2016, 20:29.

Tags

None

Referenced Files

	F29419801: D614.diff
	Sun, May 17, 14:31

	Unknown Object (File)
	Fri, May 15, 15:01

	Unknown Object (File)
	Wed, May 13, 20:29

	Unknown Object (File)
	Tue, May 12, 06:22

	Unknown Object (File)
	Mon, May 11, 15:21

	Unknown Object (File)
	Sat, May 9, 13:42

	Unknown Object (File)
	Thu, May 7, 14:04

	Unknown Object (File)
	Thu, May 7, 14:04

Subscribers

None

Details

Reviewers

Commits

rKBROKER545d2db54f4c: Explicitely set visibility to public methods

Test Plan

no op

Diff Detail

Repository

rKBROKER Keruald Broker

Lint

Lint Passed

Unit

Test Failures

Branch

visibility

Build Status

Buildable 910
Build 1059: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	29 ms	Unknown Unit Message ("") Error Connecting to server (111): Connection refused /home/ubuntu/workspace/3rdparty/keruald/broker/vendor/php-amqplib/php-amqplib/PhpAmqpLib/Wire/IO/StreamIO.php:106 /home/ubuntu/workspace/3rdparty/keruald/broker/vendor/php-amqplib/php-amqplib/PhpAmqpLib/Connection/AbstractConnection.php:195

Event Timeline

dereckson updated this revision to Diff 1506.Aug 17 2016, 20:29

dereckson retitled this revision from to Explicitely set visibility to public methods.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson updated this object.

dereckson accepted this revision.Aug 17 2016, 20:29

dereckson updated this object.

dereckson edited edge metadata.

This revision is now accepted and ready to land.Aug 17 2016, 20:30

Closed by commit rKBROKER545d2db54f4c: Explicitely set visibility to public methods (authored by dereckson, committed by dereckson). · Explain WhyAug 17 2016, 20:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

2 lines

8%

Loading...

Diff 1506

src/AMQPBroker.php

Loading...